Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::addTemplate with interwiki link was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\Scribunto\Engines\LuaCommon\TitleLibrary::getContentInternal]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::addTemplate with interwiki link was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\Scribunto\Engines\LuaCommon\TitleLibrary::getContentInternal]
error.stack_trace
from /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Engines/LuaCommon/TitleLibrary.php(299)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(379): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(350): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(231): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.26/includes/GlobalFunctions.php(773): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/ParserOutput.php(1107): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Engines/LuaCommon/TitleLibrary.php(299): MediaWiki\Parser\ParserOutput->addTemplate(MediaWiki\Title\Title, integer, integer)
#7 /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Engines/LuaCommon/TitleLibrary.php(336): MediaWiki\Extension\Scribunto\Engines\LuaCommon\TitleLibrary->getContentInternal(string)
#8 /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Engines/LuaSandbox/LuaSandboxCallback.php(31): MediaWiki\Extension\Scribunto\Engines\LuaCommon\TitleLibrary->getContent(string)
#9 [internal function]: MediaWiki\Extension\Scribunto\Engines\LuaSandbox\LuaSandboxCallback->__call(string, array)
#10 /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Engines/LuaSandbox/LuaSandboxInterpreter.php(136): LuaSandboxFunction->call(LuaSandboxFunction)
#11 /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Engines/LuaCommon/LuaEngine.php(313): MediaWiki\Extension\Scribunto\Engines\LuaSandbox\LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#12 /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Engines/LuaCommon/LuaModule.php(75): MediaWiki\Extension\Scribunto\Engines\LuaCommon\LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#13 /srv/mediawiki/php-1.42.0-wmf.26/extensions/Scribunto/includes/Hooks.php(177): MediaWiki\Extension\Scribunto\Engines\LuaCommon\LuaModule->invoke(string, PPTemplateFrame_Hash)
#14 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3418): MediaWiki\Extension\Scribunto\Hooks->invokeHook(MediaWiki\Parser\Parser, PPTemplateFrame_Hash, array)
#15 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3103): MediaWiki\Parser\Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#16 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/PPFrame_Hash.php(275): MediaWiki\Parser\Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#17 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3294): PPFrame_Hash->expand(PPNode_Hash_Tree)
#18 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/PPFrame_Hash.php(275): MediaWiki\Parser\Parser->braceSubstitution(array, PPFrame_Hash)
#19 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(2937): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#20 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(1583): MediaWiki\Parser\Parser->replaceVariables(string)
#21 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(691): MediaWiki\Parser\Parser->internalParse(string)
#22 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/WikitextContentHandler.php(376): MediaWiki\Parser\Parser->parse(string, MediaWiki\Title\Title, ParserOptions, boolean, boolean, integer)
#23 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/ContentHandler.php(1664): WikitextContentHandler->fillParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#24 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/Renderer/ContentRenderer.php(67): ContentHandler->getParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#25 /srv/mediawiki/php-1.42.0-wmf.26/includes/Revision/RenderedRevision.php(260): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(WikitextContent, MediaWiki\Title\Title, MediaWiki\Revision\RevisionStoreCacheRecord, ParserOptions, boolean)
#26 /srv/mediawiki/php-1.42.0-wmf.26/includes/Revision/RenderedRevision.php(232): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#27 /srv/mediawiki/php-1.42.0-wmf.26/includes/Revision/RevisionRenderer.php(226): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#28 /srv/mediawiki/php-1.42.0-wmf.26/includes/Revision/RevisionRenderer.php(164): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, ParserOptions, array)
#29 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#30 /srv/mediawiki/php-1.42.0-wmf.26/includes/Revision/RenderedRevision.php(199): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#31 /srv/mediawiki/php-1.42.0-wmf.26/includes/poolcounter/PoolWorkArticleView.php(91): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#32 /srv/mediawiki/php-1.42.0-wmf.26/includes/poolcounter/PoolWorkArticleViewCurrent.php(107): MediaWiki\PoolCounter\PoolWorkArticleView->renderRevision()
#33 /srv/mediawiki/php-1.42.0-wmf.26/includes/poolcounter/PoolCounterWork.php(171): MediaWiki\PoolCounter\PoolWorkArticleViewCurrent->doWork()
#34 /srv/mediawiki/php-1.42.0-wmf.26/includes/page/ParserOutputAccess.php(328): MediaWiki\PoolCounter\PoolCounterWork->execute()
#35 /srv/mediawiki/php-1.42.0-wmf.26/includes/page/Article.php(761): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
#36 /srv/mediawiki/php-1.42.0-wmf.26/includes/page/Article.php(563): Article->generateContentOutput(MediaWiki\User\User, ParserOptions, integer, MediaWiki\Output\OutputPage, array)
#37 /srv/mediawiki/php-1.42.0-wmf.26/includes/actions/ViewAction.php(78): Article->view()
#38 /srv/mediawiki/php-1.42.0-wmf.26/includes/actions/ActionEntryPoint.php(733): ViewAction->show()
#39 /srv/mediawiki/php-1.42.0-wmf.26/includes/actions/ActionEntryPoint.php(510): MediaWiki\Actions\ActionEntryPoint->performAction(Article, MediaWiki\Title\Title)
#40 /srv/mediawiki/php-1.42.0-wmf.26/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#41 /srv/mediawiki/php-1.42.0-wmf.26/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#42 /srv/mediawiki/php-1.42.0-wmf.26/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#43 /srv/mediawiki/w/index.php(3): require(string)
#44 {main}
Impact
Notes

New from 1.42.0-wmf.26.

26 hits on itwiki (from various pages such as https://it.wikipedia.org/wiki/The_Greatest_American or https://it.wikipedia.org/wiki/Aeroporto_Internazionale_di_Bangalore )
4 on enwikitionary (ex: https://en.wiktionary.org/wiki/Module:cu:Dialects )

MediaWiki\Parser\ParserOutput::addTemplate with interwikilink has been deprecated via T361330

Event Timeline

See notes in {T362221#9704263} for the implications of adding external links as page dependencies.

Change #1018733 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@master] TitleLibrary: Don't register external titles as dependencies

https://gerrit.wikimedia.org/r/1018733

Change #1018691 had a related patch set uploaded (by Hashar; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@wmf/1.42.0-wmf.26] TitleLibrary: Don't register external titles as dependencies

https://gerrit.wikimedia.org/r/1018691

Change #1018733 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] TitleLibrary: Don't register external titles as dependencies

https://gerrit.wikimedia.org/r/1018733

Change #1018691 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@wmf/1.42.0-wmf.26] TitleLibrary: Don't register external titles as dependencies

https://gerrit.wikimedia.org/r/1018691

Mentioned in SAL (#wikimedia-operations) [2024-04-10T17:02:27Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:1018691|TitleLibrary: Don't register external titles as dependencies (T362222)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-10T17:07:29Z] <hashar@deploy1002> hashar: Backport for [[gerrit:1018691|TitleLibrary: Don't register external titles as dependencies (T362222)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-10T17:21:20Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:1018691|TitleLibrary: Don't register external titles as dependencies (T362222)]] (duration: 18m 53s)

hashar assigned this task to cscott.

I have deployed the fix and confirmed it to be working. Thank you for the quick patch!

Change #1018694 had a related patch set uploaded (by Jforrester; author: C. Scott Ananian):

[mediawiki/extensions/Scribunto@REL1_42] TitleLibrary: Don't register external titles as dependencies

https://gerrit.wikimedia.org/r/1018694

Change #1018694 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@REL1_42] TitleLibrary: Don't register external titles as dependencies

https://gerrit.wikimedia.org/r/1018694