Page MenuHomePhabricator

Iconless toggle buttons on diff of the first revision of a page
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:

image.png (46×319 px, 3 KB)

What should have happened instead?:
These controls shouldn't appear in the first place, as when the two versions have no difference:
https://test.wikipedia.org/w/index.php?title=Test_article_2&diff=591459&oldid=591454

Event Timeline

Change #1017270 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Load diff modules in onTextSlotDiffRendererTablePrefix as well

https://gerrit.wikimedia.org/r/1017270

@Esanders The patch does not seem to address the problem, which is not that the icons are missing but that these toggles appear at all.

Change #1017270 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Load diff modules in onTextSlotDiffRendererTablePrefix as well

https://gerrit.wikimedia.org/r/1017270

matmarex assigned this task to Esanders.
matmarex subscribed.

@Esanders The patch does not seem to address the problem, which is not that the icons are missing but that these toggles appear at all.

Displaying the toggles seems to be intended to me, and maybe only a little bit weird, but harmless. Core's new "Inline" diff toggle behaves the same way. They can still be used to change your default diff mode.

The missing icons are fixed by the patch.