Create ApiQueryCheckUserResponseFactory service
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

A factory service is needed to allow easy construction of the subclasses of the ApiQueryCheckUserAbstractResponse abstract class. This needs to exist before subclasses are implemented to allow easier testing of the code and will initially not construct any objects.

Acceptance criteria

Create the ApiQueryCheckUserResponseFactory service
Have the factory class be able to generate response classes for the ipusers, userips and actions request types

Details

Subject	Repo	Branch	Lines /-
Add ApiQueryCheckUserActionsResponse to the response factory	mediawiki/extensions/CheckUser	master	25 -0
Add ipusers and userips response classes the for CheckUser API	mediawiki/extensions/CheckUser	master	275 -1
Add ApiQueryCheckUserResponseFactory service	mediawiki/extensions/CheckUser	master	124 -0

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T341827 Add read new support to the CheckUser API
Resolved	Dreamy_Jazz	T360962 Create ApiQueryCheckUserResponseFactory service
Resolved	Dreamy_Jazz	T360961 Create ApiQueryCheckUserAbstractResponse
		· · ·

Event Timeline

Dreamy_Jazz created this task.Mar 25 2024, 11:34 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 25 2024, 11:34 PM

Dreamy_Jazz claimed this task.Mar 25 2024, 11:35 PM

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.

Dreamy_Jazz added a subtask: T360961: Create ApiQueryCheckUserAbstractResponse.

Change #1013434 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add ApiQueryCheckUserResponseFactory service

https://gerrit.wikimedia.org/r/1013434

gerritbot added a project: Patch-For-Review.Mar 25 2024, 11:36 PM

Change #1013435 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add ipusers and userips response classes the for CheckUser API

https://gerrit.wikimedia.org/r/1013435

Change #1014139 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add ApiQueryCheckUserActionsResponse to the response factory

https://gerrit.wikimedia.org/r/1014139

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 26 2024, 12:34 AM

Change #1014147 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Mark AbstractCheckUserPager::getIpConds as hard deprecated

https://gerrit.wikimedia.org/r/1014147

Change #1013434 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add ApiQueryCheckUserResponseFactory service

https://gerrit.wikimedia.org/r/1013434

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 28 2024, 4:00 PM

Change #1013435 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add ipusers and userips response classes the for CheckUser API

https://gerrit.wikimedia.org/r/1013435

Dreamy_Jazz closed subtask T360961: Create ApiQueryCheckUserAbstractResponse as Resolved.Mar 28 2024, 5:43 PM

Change #1014139 merged by jenkins-bot: