Page MenuHomePhabricator

Linter extension, core, and Parsoid are too entangled
Open, MediumPublic

Description

In order to deploy a new lint, three different repositories need to be patched:

  1. Parsoid needs code to generate the lint, emitted as a 'type' string.
  2. The Linter extension needs the default value of its configuration variable LinterCategories extended to include the new lint type, and also a variety of metadata about the new lint (category, l10n messages, etc)
  3. Mediawiki-core contains its own localization of lint types, prefixed with`linterror-$type`. This also needs to be updated.

We should reduce this entanglement. I think it's reasonable to have Lint-related UX in the Linter extension, but Parsoid should probably defined the l10n and the metadata for the lints itself. (We didn't do this originally because Parsoid was (a) in JS not PHP and (b) not hooked up to translatewiki.)

un-entangling the system.jpeg (3×4 px, 3 MB)

Event Timeline

Change #1013589 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] SignatureValidator: Don't fail signature validation on hidden lints

https://gerrit.wikimedia.org/r/1013589

Change #1013589 merged by jenkins-bot:

[mediawiki/core@master] SignatureValidator: Don't fail signature validation on hidden lints

https://gerrit.wikimedia.org/r/1013589

Arlolra triaged this task as Medium priority.Jun 15 2024, 1:24 AM