Page MenuHomePhabricator
Create Task
Maniphest T360517

Stop using DBAccessObjectUtils::getDBOptions in CampaignEvents
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We will hard-deprecate this function before the branch cut in April 9th. So this needs to be fixed by that time. Here is an example of adoption in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /1008851/2/includes/Mentorship/Store/DatabaseMentorStore.php

This also implies queries done in those areas need to switch to SelectQueryBuilder which is not currently possible because ICampaignsDatabasedoesn't support ::newSelectQueryBuilder(). I wanted to do the work myself but due to these complexities, I'm not going to.

Details

SubjectRepoBranchLines /-
Replace usages of deprecated DBAccessObjectUtils::getDBOptionsmediawiki/extensions/CampaignEventsmaster 33 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Mar 20 2024, 11:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2024, 11:19 AM
Daimona added a project: Campaigns-Product-Team.Mar 20 2024, 3:26 PM
Daimona moved this task from Backlog to To be Estimated/Discussed on the Campaigns-Product-Team board.
ifried set the point value for this task to 2.Mar 21 2024, 2:46 PM
ifried edited projects, added Campaigns-Product-Team (Campaign-Tools-Current-Sprint); removed Campaigns-Product-Team.
ifried moved this task from Upcoming / refining 💡 to Ready for development on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.
Daimona mentioned this in T361026: Remove the ICampaignsDatabase abstraction.Mar 26 2024, 3:49 PM
Daimona added a subtask: T361026: Remove the ICampaignsDatabase abstraction.Mar 26 2024, 4:01 PM
gerritbot added a comment.Apr 4 2024, 12:53 PM

Change #1017052 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Replace usages of deprecated DBAccessObjectUtils::getDBOptions

https://gerrit.wikimedia.org/r/1017052

gerritbot added a project: Patch-For-Review.Apr 4 2024, 12:53 PM
Daimona claimed this task.Apr 4 2024, 12:54 PM
Daimona moved this task from Ready for development to Code Review 💬 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.
gerritbot added a comment.Apr 9 2024, 1:04 AM

Change #1017052 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Replace usages of deprecated DBAccessObjectUtils::getDBOptions

https://gerrit.wikimedia.org/r/1017052

cmelo moved this task from Code Review 💬 to QA 🐛 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Apr 9 2024, 1:06 AM
cmelo removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 9 2024, 2:00 AM
vaughnwalters closed subtask T361026: Remove the ICampaignsDatabase abstraction as Resolved.Apr 18 2024, 8:11 PM
vaughnwalters closed this task as Resolved.Apr 18 2024, 8:19 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.
vaughnwalters subscribed.

I have checked each special page in the campaign events extension to make sure that data is correctly displaying. Tested together with subtask T361026 - see testing notes at T361026#9728078. Marking as done / resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits