Page MenuHomePhabricator

Expand all sections feature is an unnecessary performance issue
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The Early life section is collapsed initially and then gets expanded

What should have happened instead?:

  • The section should be open from the very first render.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

This is easily fixable with client preferences code but please test on cached HTML.

QA Results - Beta

ACStatusDetails
1T358072#9775986

QA Results - PROD

ACStatusDetails
1T358072#9778045

Event Timeline

Jdlrobson triaged this task as Medium priority.Feb 21 2024, 1:17 AM

Change 997961 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Avoid repaints on collapsed sections

https://gerrit.wikimedia.org/r/997961

Not a regression no, just a long term problem that we've never been able to address until now (the client preferences API). Given the change in how Google indexes us this could potentially impact our ratings if this feature has significant usage on certain wikis.

Change #997961 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Avoid repaints on collapsed sections

https://gerrit.wikimedia.org/r/997961

Test Result - Beta

Status:
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Steps to replicate the issue (include links if applicable):

Open https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileOptions (beta -> https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileOptions) on a small screen
Make sure the expand all sections icon is checked.
Visit https://en.m.wikipedia.org/wiki/Shabana_Basij-Rasikh (beta -> https://en.m.wikipedia.beta.wmflabs.org/wiki/George_Washington) on a slow connection
✅ AC1: The Early life section should be open from the very first render.

screenshot 308.png (981×871 px, 232 KB)

Test Result - PROD

Status:
Environment: PROD
OS: macOS Sonoma 14.4.1
Browser: Chrome 124
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Steps to replicate the issue (include links if applicable):

Open https://en.m.wikipedia.org/wiki/Special:MobileOptions on a small screen
Make sure the expand all sections icon is checked.
Visit https://en.m.wikipedia.org/wiki/Shabana_Basij-Rasikh on a slow connection
✅ AC1: The Early life section should be open from the very first render.

Special:MobileOptionsResult
2024-05-07_09-03-08.png (894×762 px, 88 KB)
2024-05-07_09-04-30.png (875×800 px, 140 KB)
Edtadros subscribed.
ovasileva claimed this task.