Create GlobalBlockingBlockPurger service
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 13 2024, 5:02 PM

Description

The GlobalBlocking::purgeExpired method need to be moved to a separate service where the method is not static to allow easier testing and to be able to mock this method when testing the code that calls it.

This is because the purge method describes itself as expensive and as such could cause tests which do not verify the behaviour of the purge method to be unnecessarily slower.

Acceptance criteria

Move the GlobalBlocking::purgeExpired method to a new service
Update the method to use SQL query builders and make the method more like DatabaseBlockStore::purgeExpiredBlocks for consistency.
Fully test this new service.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T357443 here

Details

	Subject	Repo	Branch	Lines /-
	Create GlobalBlockingBlockPurger service	mediawiki/extensions/GlobalBlocking	master	268 -40

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T357385 Refactor the GlobalBlocking utility class into services
Resolved	Dreamy_Jazz	T357443 Create GlobalBlockingBlockPurger service
		· · ·

Event Timeline

Dreamy_Jazz claimed this task.Feb 13 2024, 5:02 PM

Dreamy_Jazz created this task.

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).

Dreamy_Jazz set the point value for this task to 2.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.

Change 1003023 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingBlockPurger service

https://gerrit.wikimedia.org/r/1003023

gerritbot added a project: Patch-For-Review.Feb 13 2024, 5:03 PM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.Feb 14 2024, 11:41 AM

Change 1003023 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingBlockPurger service

https://gerrit.wikimedia.org/r/1003023

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 11:30 PM

Suggested QA steps:

Install GlobalBlocking, if required
Log into an account with the steward group if you have MediaWiki-extensions-CentralAuth installed, or log into an account which has the globalblock right (you can give this right to admins using $wgGroupPermissions['sysop']['globalblock'] = true; in LocalSettings.php)
Load Special:GlobalBlock and create a block with an expiry of X seconds where X is a small integer
Wait at least X seconds before proceeding to the next step
Load Special:GlobalBlockList and verify that the block applied in step 3 appears in the list of blocks
Repeat step 3 using a different IP address
Load Special:GlobalBlockList and verify that the block from step 3 is now gone and the block from 6 is still present
Log into an account which has globalblock-whitelist (all sysop accounts have this right by default).
Load Special:GlobalBlockList and click on the local status link for the block performed in step 6
Submit the form after checking the checkbox that has a label starting with Disable this global block and providing a reason
Load Special:GlobalBlockList and verify that the block from step 6 no longer appears.

Like T357399: Create GlobalBlockingConnectionProvider, these QA suggested steps are designed around the idea of verifying that no changes were made to the functionality of the relevant code. This is because no changes to the functionality of the relevant code were made, instead this patch refactored and moved the relevant code. As such, you may want to check that no difference is observed in the functionality before and then after this change.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 2:01 AM

Dreamy_Jazz mentioned this in T357506: Create GlobalBlockLocalStatusLookup service.Feb 16 2024, 5:16 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)); removed Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).Feb 20 2024, 12:05 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

@Dreamy_Jazz There was no difference observed in the functionality from a previous commit vs current as seen in the .webms. This will be moved to Done. Thanks for all your work and steps!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (ba6da7d)17:55, 20 February 2024
OS: macOS Sonoma 14.2.1
Browser: Chrome 121, Safari 14.3
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
Special:GlobalBlock
Special:GlobalBlockList

✅AC1: https://phabricator.wikimedia.org/T357443

GlobalBlocking Current- commit 3ff1f7221510d5824fe06a14e916aba0201b91fa: Tue Feb 20 08:38:29 2024

Steps 1-7	Steps 8-11

GlobalBlocking Old- commit bffe54f3cbc809dd36389ea26e9ca05f631b3414: Fri Feb 9 15:16:07 2024

Steps 1-7	Steps 8-11

GMikesell-WMF updated the task description. (Show Details)Feb 20 2024, 7:37 PM

GMikesell-WMF moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

Dreamy_Jazz updated the task description. (Show Details)Feb 21 2024, 12:02 AM

Dreamy_Jazz closed this task as Resolved.Feb 21 2024, 12:06 AM

Create GlobalBlockingBlockPurger serviceClosed, ResolvedPublic2 Estimated Story PointsActions