Page MenuHomePhabricator
Create Task
Maniphest T356932

Allow Special:GlobalBlockList to show global blocks for accounts
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
Dreamy_Jazz
Feb 7 2024, 10:25 PM
Tags
Referenced Files
F56360513: image.png
Jul 12 2024, 2:26 AM
F56360507: image.png
Jul 12 2024, 2:26 AM
F56360509: image.png
Jul 12 2024, 2:26 AM
F56360503: image.png
Jul 12 2024, 2:26 AM
F56360622: image.png
Jul 12 2024, 2:26 AM
F56360597: image.png
Jul 12 2024, 2:26 AM
F56360863: image.png
Jul 12 2024, 2:26 AM
F56360592: image.png
Jul 12 2024, 2:26 AM
Subscribers
Aklapper
Djackson-ctr
Dreamy_Jazz

Description

Special:GlobalBlockList allows a user to see a list of active global blocks. This special page should support displaying global blocks for accounts.

This will include hiding blocks which the current user does not have the rights to see the username (i.e. the user is suppressed).

Details

SubjectRepoBranchLines /-
Update Special:GlobalBlockList for global account blocksmediawiki/extensions/GlobalBlockingmaster 400 -174
Add GlobalBlockingUserVisibilityLookup servicemediawiki/extensions/GlobalBlockingmaster 217 -94
Test GlobalBlockListPagermediawiki/extensions/GlobalBlockingmaster 114 -0
Fully test SpecialGlobalBlockListmediawiki/extensions/GlobalBlockingmaster 97 -35
Replace use of deprecated methods in GlobalBlockListPagermediawiki/extensions/GlobalBlockingmaster 65 -19
Test SpecialContributionsBeforeMainOutput handler methodmediawiki/extensions/GlobalBlockingmaster 74 -0
Move GlobalBlockingHooksTest to the unit test foldermediawiki/extensions/GlobalBlockingmaster 18 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 In ProgressNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 [Epic] Update features for temporary accounts
 OpenDreamy_JazzT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 OpenDreamy_JazzT368949 [Epic] Implement global autoblocks from global user blocks
 DeclinedNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 ResolvedFeatureDreamy_JazzT17294 Allow globally blocking of accounts
 ResolvedDreamy_JazzT358777 Rename messages with the '-new' suffix to remove this suffix
 ResolvedDreamy_JazzT358776 Remove old versions of GlobalBlocking i18n messages
 ResolvedDreamy_JazzT358773 Remove the global accounts block configuration flag
 ResolvedDreamy_JazzT356924 Deploy global account blocks to WMF wikis
 ResolvedDreamy_JazzT356932 Allow Special:GlobalBlockList to show global blocks for accounts
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 Resolved• MarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 Resolved• MarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service
 ResolvedDreamy_JazzT359584 Provide action links on Special:Log for global block entries

Event Timeline

Dreamy_Jazz created this task.Feb 7 2024, 10:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2024, 10:25 PM
Dreamy_Jazz added a parent task: T356924: Deploy global account blocks to WMF wikis.Feb 7 2024, 10:25 PM
Dreamy_Jazz added a subtask: T356936: Update GlobalBlocking services to support global block on accounts.Feb 7 2024, 10:34 PM
Dreamy_Jazz updated the task description. (Show Details)Feb 28 2024, 8:22 PM
gerritbot added a comment.Mar 4 2024, 5:31 PM

Change 1008518 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Move action link generation to GlobalBlockingLinkBuilder

https://gerrit.wikimedia.org/r/1008518

gerritbot added a project: Patch-For-Review.Mar 4 2024, 5:31 PM
Dreamy_Jazz closed subtask T356936: Update GlobalBlocking services to support global block on accounts as Resolved.Mar 27 2024, 9:40 AM
Dreamy_Jazz closed subtask T359584: Provide action links on Special:Log for global block entries as Resolved.Apr 23 2024, 4:41 PM
gerritbot added a comment.May 22 2024, 8:59 PM

Change #1009755 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update Special:GlobalBlockList for global account blocks

https://gerrit.wikimedia.org/r/1009755

Dreamy_Jazz claimed this task.May 22 2024, 9:00 PM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 23 2024, 10:06 AM
gerritbot added a comment.May 23 2024, 10:54 AM

Change #1035359 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Test SpecialContributionsBeforeMainOutput handler method

https://gerrit.wikimedia.org/r/1035359

gerritbot added a comment.May 23 2024, 10:59 AM

Change #1035360 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Move GlobalBlockingHooksTest to the unit test folder

https://gerrit.wikimedia.org/r/1035360

gerritbot added a comment.May 24 2024, 11:33 AM

Change #1035360 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Move GlobalBlockingHooksTest to the unit test folder

https://gerrit.wikimedia.org/r/1035360

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 24 2024, 12:00 PM
Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 30 2024, 3:16 PM
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 30 2024, 5:10 PM
gerritbot added a comment.May 31 2024, 10:34 PM

Change #1037862 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Replace use of deprecated methods in GlobalBlockListPager

https://gerrit.wikimedia.org/r/1037862

Dreamy_Jazz moved this task from Sprint Shekere (13th May - 24th May) to Sprint Melodica (Jun 3 - Jun 14) on the Trust and Safety Product Sprint board.Jun 3 2024, 10:12 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
Dreamy_Jazz moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
gerritbot added a comment.Jun 6 2024, 11:09 AM

Change #1035359 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test SpecialContributionsBeforeMainOutput handler method

https://gerrit.wikimedia.org/r/1035359

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.9; 2024-06-11); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Jun 6 2024, 12:00 PM
gerritbot added a comment.Jun 7 2024, 10:21 AM

Change #1037862 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Replace use of deprecated methods in GlobalBlockListPager

https://gerrit.wikimedia.org/r/1037862

Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 8 2024, 12:13 AM
Dreamy_Jazz moved this task from Ready to Priority Backlog on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 24 2024, 5:34 PM
gerritbot added a comment.Jun 24 2024, 7:07 PM

Change #1040270 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Fully test SpecialGlobalBlockList

https://gerrit.wikimedia.org/r/1040270

gerritbot added a comment.Jun 24 2024, 7:14 PM

Change #1049257 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Test GlobalBlockListPager

https://gerrit.wikimedia.org/r/1049257

Dreamy_Jazz moved this task from Sprint Melodica (Jun 3 - Jun 14) to Sprint Cajon (Jun 24 - July 5) on the Trust and Safety Product Sprint board.Jun 25 2024, 10:42 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)); removed Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)).
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jun 25 2024, 5:53 PM
Dreamy_Jazz moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
gerritbot added a comment.Jun 25 2024, 6:56 PM

Change #1049624 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Add GlobalBlockingUserVisibility service

https://gerrit.wikimedia.org/r/1049624

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jun 25 2024, 8:57 PM
gerritbot added a comment.Jul 4 2024, 3:06 PM

Change #1040270 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Fully test SpecialGlobalBlockList

https://gerrit.wikimedia.org/r/1040270

gerritbot added a comment.Jul 4 2024, 3:07 PM

Change #1049257 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test GlobalBlockListPager

https://gerrit.wikimedia.org/r/1049257

gerritbot added a comment.Jul 4 2024, 3:16 PM

Change #1049624 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add GlobalBlockingUserVisibilityLookup service

https://gerrit.wikimedia.org/r/1049624

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.13; 2024-07-09); removed MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jul 4 2024, 4:00 PM
gerritbot added a comment.Jul 10 2024, 5:08 PM

Change #1009755 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update Special:GlobalBlockList for global account blocks

https://gerrit.wikimedia.org/r/1009755

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 10 2024, 5:08 PM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 12 2024, 2:26 AM
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected.

image.png (885×449 px, 269 KB)

image.png (889×449 px, 216 KB)

image.png (723×897 px, 266 KB)

image.png (753×1 px, 402 KB)

image.png (603×1 px, 312 KB)

image.png (586×1 px, 244 KB)

image.png (566×1 px, 223 KB)

image.png (533×1 px, 278 KB)

Djackson-ctr attached a referenced file: F56360507: image.png. (Show Details)Jul 12 2024, 2:27 AM
Dreamy_Jazz closed this task as Resolved.Jul 12 2024, 5:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits