Page MenuHomePhabricator
Create Task
Maniphest T353621

Deprecation notice : trim(): Passing null to parameter #1 ($string) of type string is deprecated
Closed, ResolvedPublic
Actions

Description

Hello,

There's a deprecation notice that spits out on PHP 8.2.13 :

PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/extensions/Variables/includes/ExtVariables.php on line 198

Event Timeline

BertrandGorge created this task.Dec 18 2023, 11:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2023, 11:15 AM
Aklapper added a project: PHP 8.1 support.Dec 18 2023, 12:15 PM
MGChecker subscribed.Dec 19 2023, 7:16 PM

What precisely did you do to raise this error? Which version of Variables are you using?

MGChecker added a subscriber: Universal_Omega.Dec 19 2023, 8:20 PM

I believe that this can not be caused within Variables, but only by bad callers. (Like Loops and @Universal_Omega s Universal-Omega/DynamicPageList3.

Universal_Omega added a comment.Dec 19 2023, 8:27 PM

I believe this is fixed via DPL3 now, but not Loops, but DPL3 should be...

MGChecker added a comment.Dec 19 2023, 10:14 PM

Tbh, I have not checked in detail whether Loops may present this issue.

BertrandGorge added a comment.Dec 20 2023, 8:34 AM

Hello, let me get back to you with more information - I might reproduce locally and check the calling stack. But yes, we are using loops, DPL3 and all sort of stuff...!

Reedy moved this task from Backlog to Other on the PHP 8.1 support board.Jan 13 2024, 1:14 AM
Dinoguy1000 edited projects, added PHP 8.2 support; removed PHP 8.1 support.Feb 22 2024, 3:36 PM
Schtom subscribed.EditedMar 4 2024, 3:50 PM

MW 1.39.6
PHP 8.1.27

updating DPL3 to b0483e04acb5e64a06cb6c0030ec30d1f587fef4 which includes version 3.5.2 fixed this issue for me

Reedy moved this task from Backlog to Other on the PHP 8.2 support board.Mar 4 2024, 3:51 PM
Universal_Omega added a comment.Mar 4 2024, 5:13 PM
In T353621#9596572, @Schtom wrote:

MW 1.39.6
PHP 8.1.27

updating DPL3 to b0483e04acb5e64a06cb6c0030ec30d1f587fef4 which includes version 3.5.2 fixed this issue for me

Thanks very much for confirming... I was unsure if this had fully been fixed, but it seems so, so thanks for confirming that.

MGChecker closed this task as Resolved.Mar 11 2024, 9:45 PM
MGChecker assigned this task to Universal_Omega.

@BertrandGorge Seems to be resolved, if you still experience this issue after upgrading, please reopen.

BertrandGorge added a comment.Mar 13 2024, 5:46 PM

Yes I confirm the latest version of DPL (master branch) fixes the issue. Should I point to master then, and not REL1_39 ?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits