Page MenuHomePhabricator
Create Task
Maniphest T352016

Stop showing IP warning on Lexeme SpecialPages for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic
Actions

Description

Problem:
We are showing warnings when edits are made via SpecialPages to Lexemes and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.
This applies to all edits to Lexemes that are done via SpecialPages.

Affected SpecialPages:

  • Create Lexeme (both js and non-js)
  • Merge Lexeme

Acceptance criteria:

  • IP leak warning isn't shown when editing Lexemes via SpecialPages when IP Masking is enabled

Details

SubjectRepoBranchLines /-
Change AnonymousEditWarning to add TempUser supportmediawiki/extensions/WikibaseLexememaster 23 -5
Change AnonymousEditWarning to support IP-masking / tempusermediawiki/extensions/WikibaseLexememaster 33 -10
Use new AnonymousEditWarningBuilder Servicemediawiki/extensions/WikibaseLexememaster 26 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arian_Bozorg created this task.Nov 27 2023, 11:56 AM
Arian_Bozorg mentioned this in T351970: [EPIC] Stop showing IP warning on SpecialPages for Wikibase instances that have temporary accounts enabled.Nov 27 2023, 1:03 PM
Arian_Bozorg moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Dec 5 2023, 3:12 PM
ArthurTaylor moved this task from Product Backlog to Wikidata.org Slice on the Wikidata Dev Team board.Dec 19 2023, 2:54 PM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Dec 19 2023, 2:57 PM

Change 984100 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseLexeme@master] Change AnonymousEditWarning to support IP-masking / tempuser

https://gerrit.wikimedia.org/r/984100

gerritbot added a project: Patch-For-Review.Dec 19 2023, 2:57 PM
Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Dec 19 2023, 3:29 PM
ArthurTaylor moved this task from In Development to Ready for Development on the Wikidata Dev Team (Wikidata.org Slice) board.Dec 20 2023, 10:23 AM
gerritbot added a comment.Dec 21 2023, 9:49 AM

Change 984804 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseLexeme@master] Use new AnonymousEditWarningBuilder Service

https://gerrit.wikimedia.org/r/984804

gerritbot added a comment.Dec 21 2023, 2:24 PM

Change 984804 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use new AnonymousEditWarningBuilder Service

https://gerrit.wikimedia.org/r/984804

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 21 2023, 3:00 PM
gerritbot added a comment.Dec 21 2023, 3:17 PM

Change 984100 abandoned by Arthur taylor:

[mediawiki/extensions/WikibaseLexeme@master] Change AnonymousEditWarning to support IP-masking / tempuser

Reason:

Not needed since I3153030242a3ac597fd7b160897079747c77d648 was merged

https://gerrit.wikimedia.org/r/984100

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2023, 3:31 PM
ArthurTaylor claimed this task.Dec 22 2023, 11:09 AM
ArthurTaylor moved this task from Ready for Development to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.Dec 22 2023, 11:13 AM
Michael renamed this task from Stop showing IP warning on Lexeme pages for Wikibase instances that have temporary accounts enabled to Stop showing IP warning on Lexeme SpecialPages for Wikibase instances that have temporary accounts enabled.Dec 22 2023, 2:26 PM
ArthurTaylor added a comment.Dec 22 2023, 2:57 PM

Merge Lexeme is already addressed in T352017, and a fix is included in 984210

gerritbot added a comment.Dec 27 2023, 12:25 PM

Change 986189 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseLexeme@master] Change AnonymousEditWarning to add TempUser support

https://gerrit.wikimedia.org/r/986189

gerritbot added a project: Patch-For-Review.Dec 27 2023, 12:25 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Jan 4 2024, 12:29 PM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Jan 5 2024, 1:02 PM
ArthurTaylor moved this task from Ready for Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor subscribed.
gerritbot added a comment.Jan 5 2024, 1:17 PM

Change 986189 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Change AnonymousEditWarning to add TempUser support

https://gerrit.wikimedia.org/r/986189

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2024, 1:30 PM
Arian_Bozorg closed this task as Resolved.Jan 10 2024, 2:45 PM
Arian_Bozorg claimed this task.
Arian_Bozorg closed subtask T352018: Stop showing IP warning on Create Lexeme (both js and non-js) for Wikibase instances that have temporary accounts enabled as Resolved.
Arian_Bozorg closed subtask T352017: Stop showing IP warning on Merge Lexeme for Wikibase instances that have temporary accounts enabled as Resolved.
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

Looks good to me! Thanks so much :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits