Page MenuHomePhabricator
Create Task
Maniphest T348835

Migrate code to use new query builder functions
Closed, ResolvedPublic
Actions

Description

wikitech announcement

Details

SubjectRepoBranchLines /-
Change Database::upsert to Database::newInsertQueryBuildermediawiki/extensions/PageTriagemaster 8 -6
Change Database::replace to Database::newReplaceQueryBuildermediawiki/extensions/PageTriagemaster 12 -12
Change Database::insert to Database::newInsertQueryBuildermediawiki/extensions/PageTriagemaster 117 -95
Customize query in gerrit

Related Objects
Search...

Event Timeline

MPGuy2824 created this task.Oct 13 2023, 7:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2023, 7:47 AM
MPGuy2824 added subtasks: T339387: Migrate remaining select queries to newSelectQueryBuilder, T312480: Migrate usage of Database::select to SelectQueryBuilder in PageTriage, T331279: Migrate Database::update usages to UpdateQueryBuilder in PageTriage, T335748: Migrate Database::delete usages to DeleteQueryBuilder in PageTriage.Oct 13 2023, 7:49 AM
MPGuy2824 moved this task from Backlog to Priority technical debt on the PageTriage board.
MPGuy2824 mentioned this in T350966: Use expression builder instead of raw SQL in PageTriage.Nov 11 2023, 3:44 AM
gerritbot added a comment.Jan 19 2024, 7:50 AM

Change 991697 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Change Database::upsert to Database::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/991697

gerritbot added a project: Patch-For-Review.Jan 19 2024, 7:50 AM
gerritbot added a comment.Jan 19 2024, 8:22 AM

Change 991735 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Change Database::replace to Database::newReplaceQueryBuilder

https://gerrit.wikimedia.org/r/991735

gerritbot added a comment.Jan 19 2024, 10:54 AM

Change 991751 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Change Database::insert to Database::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/991751

MPGuy2824 updated the task description. (Show Details)Jan 19 2024, 10:57 AM
gerritbot added a comment.Jan 19 2024, 7:09 PM

Change 991751 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Change Database::insert to Database::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/991751

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 19 2024, 9:00 PM
MPGuy2824 changed the task status from Open to In Progress.Jan 20 2024, 3:47 AM
MPGuy2824 claimed this task.
MPGuy2824 changed the status of subtask T339387: Migrate remaining select queries to newSelectQueryBuilder from Open to In Progress.
MPGuy2824 updated the task description. (Show Details)
MPGuy2824 moved this task from Priority technical debt to Code Review on the PageTriage board.
gerritbot added a comment.Jan 20 2024, 3:28 PM

Change 991735 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Change Database::replace to Database::newReplaceQueryBuilder

https://gerrit.wikimedia.org/r/991735

Novem_Linguae moved this task from Code Review to Priority technical debt on the PageTriage board.Feb 14 2024, 1:59 AM
gerritbot added a comment.Feb 15 2024, 5:00 PM

Change 991697 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Change Database::upsert to Database::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/991697

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.19; 2024-02-20); removed MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Feb 15 2024, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 5:31 PM
Novem_Linguae closed this task as Resolved.Feb 16 2024, 8:38 AM
Novem_Linguae closed subtask T339387: Migrate remaining select queries to newSelectQueryBuilder as Resolved.
Novem_Linguae updated the task description. (Show Details)
Novem_Linguae updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits