Popups should use Codex markup instead of mw-ui-icon markup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 14 2023, 6:13 PM

Description

Popups still uses the mw-ui-icon class. Instead it should be modified to use the Codex markup.

TODO

Use The cdx-icon CSS version and codex mixin styles https://doc.wikimedia.org/codex/latest/components/demos/icon.html#css-only-version

QA

No large visual changes in popups, especially looking at all button and icons
Make sure to check disambiguation, reference and error popups

Sign off

T345653 will remove the icon selectors

Details

	Subject	Repo	Branch	Lines /-
	Replace mediawiki.ui.icon with Codex, update preview markup and styles to be more consistent	mediawiki/extensions/Popups	master	98 -111

Customize query in gerrit

Related Objects

Mentioned In: T352179: Reference previews broken for references with % in the name
T345781: Reference preview settings cog doesn't do anything when clicked
T340256: Popups: Use Codex markup for buttons instead of mediawiki.ui markup
Mentioned Here: T345653: Follow up work: Clean up icon classes in Popups

Event Timeline

Jdlrobson created this task.Jul 14 2023, 6:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2023, 6:13 PM

Jdlrobson triaged this task as Medium priority.Jul 14 2023, 6:13 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3); removed Web-Team-Backlog.

Jdlrobson mentioned this in T340256: Popups: Use Codex markup for buttons instead of mediawiki.ui markup.

bwang set the point value for this task to 2.Jul 20 2023, 5:59 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3).Jul 31 2023, 5:58 PM

Jdlrobson raised the priority of this task from Medium to High.Aug 7 2023, 5:38 PM

High as this is the last remaining consumer of this code in desktop.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.Aug 10 2023, 5:58 PM

bwang claimed this task.Aug 14 2023, 4:46 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

Change 949095 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Replace mediawiki.ui.icon with Codex, update preview markup and styles to be more consistent

https://gerrit.wikimedia.org/r/949095

gerritbot added a project: Patch-For-Review.Aug 15 2023, 6:21 PM

bwang removed bwang as the assignee of this task.Aug 15 2023, 7:38 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

bwang subscribed.

Jdrewniak claimed this task.Aug 16 2023, 2:57 PM

Change 949095 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Replace mediawiki.ui.icon with Codex, update preview markup and styles to be more consistent

https://gerrit.wikimedia.org/r/949095

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2023, 8:11 PM

bwang removed Jdrewniak as the assignee of this task.Aug 22 2023, 4:37 PM

bwang moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

bwang added a subscriber: Jdrewniak.

Hey @bwang can you add some test steps. I'm not sure how to validate this properly.

bwang updated the task description. (Show Details)Aug 24 2023, 4:46 PM

Edtadros claimed this task.Aug 28 2023, 4:33 PM

Test Result - Beta

Status:❓Need More Info
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: No large visual changes in popups, especially looking at all button and icons
No large visual changes.

❓ AC2: Make sure to check disambiguation, reference and error popups
I wasn't sure what to check beyond visually. I assumed that there should be no instances of mw-icon-... Please see the circled sections and confirm if this is a pass. Additionally, I'm not sure where to find an error popup.

Screenshot 2023-08-28 at 6.41.56 PM.png (1×1 px, 691 KB)

Screenshot 2023-08-28 at 6.46.47 PM.png (1×1 px, 559 KB)

Screenshot 2023-08-28 at 6.49.55 PM.png (1×1 px, 564 KB)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 11:01 PM

Yes those look like passes to me!

bwang removed bwang as the assignee of this task.Sep 5 2023, 5:32 PM

bwang moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.

Edtadros moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.Sep 5 2023, 5:39 PM

Jdlrobson assigned this task to Edtadros.Sep 5 2023, 5:40 PM

Jdlrobson mentioned this in T345781: Reference preview settings cog doesn't do anything when clicked.Sep 6 2023, 9:49 PM

Test Result - Prod

Status: ❓Need More Info
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

❓ AC1: No large visual changes in popups, especially looking at all button and icons
@Jdlrobson , a few popups have cutoff images. I'm not sure if this is an issue.

✅ AC2: Make sure to check disambiguation, reference and error popups

LGTM. Confirming as pass.

thiemowmde mentioned this in T352179: Reference previews broken for references with % in the name.Nov 28 2023, 2:23 PM

	F37639621: Screenshot 2023-08-28 at 6.49.55 PM.png
	Aug 29 2023, 2:02 AM

	F37670724: screenshot 8.png
	Sep 8 2023, 12:24 AM

	F37670722: screenshot 11.png
	Sep 8 2023, 12:24 AM

	F37670723: screenshot 6.png
	Sep 8 2023, 12:24 AM

	F37670725: screenshot 5.png
	Sep 8 2023, 12:24 AM

Popups should use Codex markup instead of mw-ui-icon markupClosed, ResolvedPublic2 Estimated Story PointsActions

Description

TODO

QA

Sign off

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Popups should use Codex markup instead of mw-ui-icon markup
Closed, ResolvedPublic2 Estimated Story Points
Actions