Page MenuHomePhabricator

Add “don’t show this again” checkbox to `mul` popup in desktop termbox
Closed, ResolvedPublic

Description

See parent task for details. After the help popup has been implemented (T340643), this adds the “don’t show this again” checkbox, the code for saving this option, and also the code for checking this option to decide whether the pulsating dot should be added or not.

Event Timeline

Lucas_Werkmeister_WMDE changed the task status from Open to Stalled.Jun 28 2023, 1:08 PM
Lucas_Werkmeister_WMDE created this task.

Stalled until the popup exists in the first place (T340643).

See Controller.js in MediaWiki core for an example of how to access and change the user options. (Edit: See also T316769#8927033.)

ItamarWMDE changed the task status from Stalled to Open.Jul 12 2023, 3:28 PM

Change 937592 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/Wikibase@master] Add Dont show this again checkbox to Mul Popup

https://gerrit.wikimedia.org/r/937592

Change 937592 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add 'Dont show this again' checkbox to Mul Popup

https://gerrit.wikimedia.org/r/937592

Works great for logged-in users!

It has, however, no functionality for non-logged-in users. This is fine if the whole onboarding element (pulsating dot) is shown only to logged-in users. My assumption is that this will be covered in a separate sub-task, so I am still closing this.

I believe this is the separate sub-task: T342872 Only show pulsating dot to logged-in users