Page MenuHomePhabricator

[Visual design bug] Vue version of tooltip pop-up header icons are misaligned with header text
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
RHo
Jun 23 2023, 2:15 PM
Referenced Files
Restricted File
Aug 18 2023, 7:14 AM
F37562584: Screen Shot 2023-08-18 at 8.42.10 AM.png
Aug 18 2023, 6:29 AM
F37562600: Screen Shot 2023-08-18 at 8.36.30 AM.png
Aug 18 2023, 6:29 AM
F37114858: Screenshot 2023-06-23 at 18.31.10.png
Jun 23 2023, 5:26 PM
F37114853: Screenshot 2023-06-23 at 18.34.23.png
Jun 23 2023, 5:26 PM
F37114850: Screenshot 2023-06-23 at 18.31.31.png
Jun 23 2023, 5:26 PM
F37114667: image.png
Jun 23 2023, 2:15 PM
F37114658: image.png
Jun 23 2023, 2:15 PM

Description

Steps to replicate the issue (include links if applicable):
Go to the Growth features where there is a tooltip built in Vue - for example the Special:Homepage new impact module.
Click/tap on the info icon to show the pop up.

What happens?:
Both the info icon and close icon button are misaligned with text.

image.png (384×722 px, 62 KB)

What should have happened instead?:
The icons should be vertically aligned with the header text, and padding is per the equivalent pop-up in OOUI

image.png (338×726 px, 44 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Thanks for filing this issue. I agree there's some miss-alignment issue in the tooltip header. Trying to provide a fix that also works for other existing use cases that are probably also carrying this issue.

From the current use cases I think we might want the following options configurable:

  • title?: text to display as title. Default none.
  • headerIcon?: icon to display as a title prefix. Default none.
  • placement?: one of "above", "below" (and probably "left" and "right" in the future). Default below.
moduleuse casecurrent implementationCurrentAfter fix
New Impact moduleinfo icon in score cardsplacement below, has title, has header icon, has close button
Screenshot 2023-06-23 at 18.31.31.png (1×800 px, 156 KB)
todo
New Impact moduleclock icon in articles listplacement above, only text
Screenshot 2023-06-23 at 18.34.23.png (608×666 px, 76 KB)
todo
Mentor Dashboardinfo in mentees tableplacement below, has title, has close button
Screenshot 2023-06-23 at 18.31.10.png (1×1 px, 253 KB)
todo

If we can draft an initial spec (no Figma needed, just business rules) maybe this component can eventually be upstreamed to Codex. Currently the Tooltip links in Codex_Planned_Components are poiniting to tangential issues but maybe we can align this implementation with the needs from T339379: Follow up work: Iterate on IP masking banner and T280677: Revise and extend the info / help tooltip pop-up in our design component library

Change 933126 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Vue components: popover header alignment

https://gerrit.wikimedia.org/r/933126

Hiya sorry for late response but I think we want the title to be flexible to be bold or not.
And perhaps we can backlog the addition of the callout arrow if it is a larger issue to tackle.

Hiya sorry for late response but I think we want the title to be flexible to be bold or not.

No issues, done. The title remains bold in the Mentor dashboard and with regular font weight for the NewImpact module

And perhaps we can backlog the addition of the callout arrow if it is a larger issue to tackle.

As mentioned in our meeting, given the clipping arrow is not critical I'd rather not start an ad-hoc GrowthExperiments implementation and join efforts with Design-System-Team in T340456.

Sgs changed the task status from Open to In Progress.Jul 13 2023, 6:27 PM
Sgs moved this task from Needs Discussion to Sprint 0 (Growth Team) on the Growth-Team board.
Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 933126 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Vue components: popover header alignment

https://gerrit.wikimedia.org/r/933126

Urbanecm_WMF changed the task status from In Progress to Open.Aug 11 2023, 10:13 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Checked on testwiki wmf.22 - added the screenshots to the table below:

moduleuse casecurrent implementationCurrentAfter fix testwiki wmf.22
New Impact moduleinfo icon in score cardsplacement below, has title, has header icon, has close button
Screenshot 2023-06-23 at 18.31.31.png (1×800 px, 156 KB)
{F37563392}
New Impact moduleclock icon in articles listplacement above, only text
Screenshot 2023-06-23 at 18.34.23.png (608×666 px, 76 KB)
Screen Shot 2023-08-18 at 8.36.30 AM.png (772×850 px, 103 KB)
Mentor Dashboardinfo in mentees tableplacement below, has title, has close button
Screenshot 2023-06-23 at 18.31.10.png (1×1 px, 253 KB)
Screen Shot 2023-08-18 at 8.42.10 AM.png (940×982 px, 118 KB)
RHo moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.
RHo added a subscriber: JFernandez-WMF.

Thanks @Etonkovidova - re-opening to move for design review by @JFernandez-WMF, since it is a visual bug.

Not sure if we have an spec to review against but joining efforts in T340456: Tooltip: Add Tooltip component to Codex would be ideal. Assigning @JFernandez-WMF for visibility, priority remains to decide by product.

hi @Sgs reading through the task right now and just want to clarify if there's anything needed from design in terms of specs / working through this with DST? should KS and I decide on what level of priority this needs?

KStoller-WMF subscribed.

Given our limited engineering capacity, I think it makes sense to resolve this for now, and wait until T340456: Tooltip: Add Tooltip component to Codex to make further improvements.