Page MenuHomePhabricator

MUL - Remove descriptions for `mul` language code from the user workflow on desktop termbox [2 of 2: when editing]
Closed, ResolvedPublic3 Estimated Story Points

Description

Problem:
Currently, it appears as if editors can add mul descriptions in the termbox. But when they try, they receive an error message, that says mul is not allowed for descriptions. We need to make this more intuitive.

Notes:

  • In story writing, it was decided to split the original task into viewing (T329644) and editing (T338302).
  • T332174 does the same thing for mobile
  • The reason is that we only allow the language code mul for Labels and Aliases and not for descriptions (T313027).

Solution:

  • Remove descriptions for mul language code from the users' termbox workflow
  • On edit mode, the description field in the termbox is disabled, and displays a placeholder that says "not applicable"

Mockups:

Screenshot 2023-06-12 at 19.17.45.png (1×2 px, 552 KB)

Acceptance criteria:

  • When editing an Item on desktop, the termbox shows a disabled edit field for descriptions for mul (see mockup).
  • Users of screen reader technology receive the right prompt on edit mode (see specs)
  • Release to test.wikidata.org

Considerations:

  • UX: The visual appearance of disabled fields in the termbox is unclear. In case the background changes color (e.g., from white to gray), we might run into a contrast issue that would require adjusting the design specs.

Event Timeline

ItamarWMDE set the point value for this task to 3.Jun 13 2023, 9:59 AM
ItamarWMDE removed a subscriber: BanMeAlreadyLMAO.

Task Breakdown Notes

  • we see no subtasks to breakdown here, this consists of making the description field uneditable for MUL language code and adding a translation message to be shown in the field
  • we should find out if screen readers can identify a disabled field and describe it well enough, otherwise this might also require a more descriptive alt text (and if we end up adding that it should probably also be translatable)
  • remember to run it through UX post implementation to make a decision about appearance
  • For any style related changes check out this file extensions/Wikibase/view/resources/jquery/wikibase/themes/default/jquery.wikibase.descriptionview.css:17

Change 930174 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Termbox: Mark mul descriptions as not applicable

https://gerrit.wikimedia.org/r/930174

Change 932226 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Fix wikibase-descriptionview-mul template for editing

https://gerrit.wikimedia.org/r/932226

Change 932226 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix wikibase-descriptionview-mul template for editing

https://gerrit.wikimedia.org/r/932226

Change 930174 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Termbox: Mark mul descriptions as not applicable

https://gerrit.wikimedia.org/r/930174

Hi, thx for the ping! I will verify this after it is deployed on Test Wikidata.