Steps to replicate the issue (include links if applicable):
- Ensure you have DiscussionTools turned on and you're logged in
- Navigate to https://pl.wikipedia.org/wiki/Wikipedia:Strona_główna?uselang=en
- You can navigate to any page in Wikipedia: namespace as well
What happens?:
There's a Subscribe action in the Tools menu.
What should have happened instead?:
The main page is definitely not a discussion page and the "Subscribe" button is useless there. It creates an impression that the extension is wrong at sensing what's the page content as well.
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
Currently, the "Subscribe" button for the whole page is shown if any of the following is met:
- the namespace permits signatures (talk or in $wgExtraSignatureNamespaces) - introduced by T249036
- there's __NEWSECTIONLINK__ present on a page
I feel like it's a too broad assuption for page-level subscription as it includes pages that were never meant to contain discussion (since $wgExtraSignatureNamespaces means there are pages there that house discussions and not all pages there house discussions). I'd rather make the reasoning like show Subscribe if we are in talk namespace or there is new section link available, which is usually present on wiki discussion pages outside of talk NS.
Note: comment recognition conditions should probably stay unchaged from what's now, since it doesn't affect a page without comments.