Page MenuHomePhabricator
Create Task
Maniphest T334794

Section=new (commentbox inputbox) is broken in MobileFrontEnd
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia): Appears in Wikipedia since this week

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines /-
Mobile editor: Don't try to take over if the form has already been submittedmediawiki/extensions/MobileFrontendwmf/1.41.0-wmf.4 4 -0
Mobile editor: Don't try to take over if the form has already been submittedmediawiki/extensions/MobileFrontendmaster 4 -0
Customize query in gerrit

Related Objects

Event Timeline

eranroz created this task.Apr 15 2023, 4:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2023, 4:36 PM
eranroz updated the task description. (Show Details)Apr 15 2023, 4:37 PM
Wargo subscribed.Apr 16 2023, 8:34 AM
Wargo added a comment.Apr 16 2023, 8:42 AM

Maybe another result of changes in T334263

Nardog subscribed.Apr 16 2023, 4:38 PM
matmarex added a project: Editing-team.Apr 17 2023, 2:28 AM
matmarex moved this task from Backlog to Team:Editing on the MobileFrontend board.
matmarex claimed this task.Apr 17 2023, 5:18 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.
gerritbot added a comment.Apr 17 2023, 5:18 PM

Change 909318 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909318

gerritbot added a project: Patch-For-Review.Apr 17 2023, 5:18 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Apr 17 2023, 5:24 PM
gerritbot added a comment.Apr 17 2023, 7:02 PM

Change 909318 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909318

gerritbot added a comment.Apr 17 2023, 7:10 PM

Change 909274 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.4] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909274

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 7:10 PM
gerritbot added a project: Patch-For-Review.Apr 17 2023, 7:10 PM
gerritbot added a comment.Apr 17 2023, 8:18 PM

Change 909274 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.4] Mobile editor: Don't try to take over if the form has already been submitted

https://gerrit.wikimedia.org/r/909274

Stashbot added a comment.Apr 17 2023, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:26:37Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]]

Stashbot mentioned this in T334799: Editor doesn't load when editing CSS/JS/Lua on mobile.Apr 17 2023, 8:26 PM
Stashbot mentioned this in T334877: Unable to publish changes to fr.m.wikipedia.org.
Stashbot mentioned this in T334797: Impossible to edit without JS or undo an edit on mobile site (414 URI Too Long).

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:27:49Z] <urbanecm@deploy2002> urbanecm and matmarex: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 8:31 PM
Stashbot added a comment.Apr 17 2023, 8:35 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-17T20:35:52Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:909274|Mobile editor: Don't try to take over if the form has already been submitted (T334794 T334797 T334877)]], [[gerrit:909275|Mobile editor: Don't try to take over on non-wikitext content (T334799)]] (duration: 09m 14s)

matmarex closed this task as Resolved.Apr 17 2023, 8:50 PM
matmarex added a project: Skipped QA.
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.

The mobile editor should be functional in this scenario again. Sorry about that.

matmarex added a comment.Apr 17 2023, 8:56 PM

By the way, you can now use DiscussionTools for comment boxes with preloaded content like this, by adding usedt=1 in the <inputbox> definition. This will likely make for a more pleasant experience than the wikitext editor. Details: https://www.mediawiki.org/wiki/Help:DiscussionTools#Experimental:_Preloading_message_content

neriah subscribed.Apr 18 2023, 6:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits