IP Masking (CommTech): TemplateWizard
Closed, ResolvedPublic
Actions

Description

This task is for tracking work to update the TemplateWizard extension ahead of IP Masking being enabled on WMF sites.

See T326816: [Epic] Update features for temporary accounts, particularly What will be affected.

Details

	Subject	Repo	Branch	Lines /-
	Do not track user ids of temporary accounts	mediawiki/extensions/TemplateWizard	master	1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 [Epic] Update features for temporary accounts
Resolved	MusikAnimal	T326873 Update Community Tech-owned products that may be affected by IP Masking
Resolved	Samwilson	T329775 IP Masking (CommTech): TemplateWizard

Event Timeline

• JMcLeod_WMF created this task.Feb 15 2023, 5:33 PM

Samwilson claimed this task.Mar 23 2023, 9:32 AM

• JMcLeod_WMF unsubscribed.Mar 30 2023, 1:27 PM

TemplateWizard has only one place where it does something different for anonymous vs logged-in users, which is when it logs an event with EventLogging. It uses mw.user.isAnon() for this, which returns false for temp users, and so it doesn't look like any changes are required in order to confirm to IP Masking requirements.

Interestingly, TemplateData does a similar thing for tracking, but uses mw.user.getId() directly and without checking if the user is logged in — I suspect this is probably fine, because EventLogging treats an ID of 0 as anonymous anyway. So we might be able to simplify the code in TemplateWizard (but that doesn't really matter for the current task).

tl;dr: nothing to be done.

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Apr 13 2023, 7:21 AM

Should we close this? I haven't reviewed TemplateWizard in depth but will definitely take Sam's word for it that no changes are needed with respect to IP masking :)