Page MenuHomePhabricator
Create Task
Maniphest T329672

"No such service: EventBus.EventBusFactory" error from GrowthExperiments extension
Closed, ResolvedPublicBUG REPORT
Actions

Description

Pixel was unusable today due to the following error:

MediaWiki internal error.

Original exception: [a5d3b092aa498d5295823921] / Wikimedia\Services\NoSuchServiceException: No such service: EventBus.EventBusFactory
Backtrace:
from /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(431)
#0 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService()
#1 /var/www/html/w/includes/MediaWikiServices.php(306): Wikimedia\Services\ServiceContainer->getService()
#2 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(419): MediaWiki\MediaWikiServices->getService()
#3 /var/www/html/w/extensions/GrowthExperiments/ServiceWiring.php(994): Wikimedia\Services\ServiceContainer->get()
#4 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}()
#5 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService()
#6 /var/www/html/w/includes/MediaWikiServices.php(306): Wikimedia\Services\ServiceContainer->getService()
#7 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(419): MediaWiki\MediaWikiServices->getService()
#8 /var/www/html/w/extensions/GrowthExperiments/includes/GrowthExperimentsServices.php(334): Wikimedia\Services\ServiceContainer->get()
#9 /var/www/html/w/extensions/GrowthExperiments/ServiceWiring.php(116): GrowthExperiments\GrowthExperimentsServices->getEventGateImageSuggestionFeedbackUpdater()
#10 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}()
#11 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService()
#12 /var/www/html/w/includes/MediaWikiServices.php(306): Wikimedia\Services\ServiceContainer->getService()
#13 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(419): MediaWiki\MediaWikiServices->getService()
#14 /var/www/html/w/extensions/GrowthExperiments/includes/GrowthExperimentsServices.php(294): Wikimedia\Services\ServiceContainer->get()
#15 /var/www/html/w/extensions/GrowthExperiments/ServiceWiring.php(231): GrowthExperiments\GrowthExperimentsServices->getAddImageSubmissionHandler()
#16 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}()
#17 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService()
#18 /var/www/html/w/includes/MediaWikiServices.php(306): Wikimedia\Services\ServiceContainer->getService()
#19 /var/www/html/w/vendor/wikimedia/services/src/ServiceContainer.php(419): MediaWiki\MediaWikiServices->getService()
#20 /var/www/html/w/extensions/GrowthExperiments/includes/GrowthExperimentsServices.php(126): Wikimedia\Services\ServiceContainer->get()
#21 /var/www/html/w/extensions/GrowthExperiments/ServiceWiring.php(217): GrowthExperiments\GrowthExperimentsServices->getImageRecommendationProviderUncached()

As a quick fix, I disabled the GrowthExperiments extension in Pixel's LocalSettings.php.

This ticket encompasses the work required to stop this error from happening when the GrowthExperiments extension is enabled again.

Details

SubjectRepoBranchLines /-
Soften dependency on EventBusmediawiki/extensions/GrowthExperimentsmaster 14 -11
Customize query in gerrit

Event Timeline

• nray created this task.Feb 14 2023, 8:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2023, 8:02 PM
Sgs added a project: Growth-Team (Sprint 0 (Growth Team)).Feb 15 2023, 12:09 PM
Sgs moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs subscribed.
Sgs added a comment.EditedFeb 15 2023, 12:35 PM

Thanks for the report nray. I think this due to the fact the EventBus.EventBusFactory is a service provided by the EventBus extension (see Extension:EventBus). The service is used to gather the feedback users provide when accepting/rejecting possible edits when using the GrowthFeatures. If disabling is an option for you that's fine, if you want to use growth features you can install the EventBus extension for now.

I will check with the team how can we soften this dependency as its only needed for one of the growth features. (introduced in I0d2f5f977254b2d4329f54b6682726a87066b98c).

Sgs moved this task from Ready for Development to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 15 2023, 12:38 PM
gerritbot added a comment.Feb 15 2023, 10:56 PM

Change 889645 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Soften dependency on EventBus

https://gerrit.wikimedia.org/r/889645

gerritbot added a project: Patch-For-Review.Feb 15 2023, 10:56 PM
• nray added a comment.Feb 15 2023, 11:05 PM

Thanks for the explanation @Sgs! I see the patch to make it a soft dependency, so I'll probably wait until that's merged before re-enabling the extension

Tgr assigned this task to Urbanecm_WMF.Feb 16 2023, 1:53 AM
Tgr moved this task from Blocked / Needs work to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 16 2023, 2:09 AM

Change 889645 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Soften dependency on EventBus

https://gerrit.wikimedia.org/r/889645

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 2:10 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 16 2023, 3:00 AM
Urbanecm_WMF added a comment.Feb 16 2023, 10:08 AM

@nray This should now be resolved. Please feel free to let us know if re-enabling the extension still causes some issues!

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 16 2023, 11:04 PM
kostajh closed this task as Resolved.Mar 8 2023, 12:55 PM
• nray added a comment.Mar 8 2023, 7:19 PM

Sorry for the lack of response here! I've just submitted a PR to re-enable this . Thank you for fixing!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits