Page MenuHomePhabricator

Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.10/includes/libs/rdbms/platform/SQLPlatform.php(1944)
#0 /srv/mediawiki/php-1.40.0-wmf.10/includes/libs/rdbms/platform/SQLPlatform.php(1877): Wikimedia\Rdbms\Platform\SQLPlatform->normalizeUpsertKeys(array)
#1 /srv/mediawiki/php-1.40.0-wmf.10/includes/libs/rdbms/database/Database.php(1914): Wikimedia\Rdbms\Platform\SQLPlatform->normalizeUpsertParams(array, array)
#2 /srv/mediawiki/php-1.40.0-wmf.10/includes/libs/rdbms/database/DBConnRef.php(119): Wikimedia\Rdbms\Database->upsert(string, array, array, array, string)
#3 /srv/mediawiki/php-1.40.0-wmf.10/includes/libs/rdbms/database/DBConnRef.php(551): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#4 /srv/mediawiki/php-1.40.0-wmf.10/extensions/GrowthExperiments/includes/UserImpact/DatabaseUserImpactStore.php(68): Wikimedia\Rdbms\DBConnRef->upsert(string, array, array, array, string)
#5 /home/tgr/T323958-deploy-newimpact/refreshUserImpactData.php(105): GrowthExperiments\UserImpact\DatabaseUserImpactStore->setUserImpact(GrowthExperiments\UserImpact\ExpensiveUserImpact)
#6 /srv/mediawiki/php-1.40.0-wmf.10/maintenance/includes/MaintenanceRunner.php(309): GrowthExperiments\Maintenance\RefreshUserImpactData->execute()
#7 /srv/mediawiki/php-1.40.0-wmf.10/maintenance/doMaintenance.php(85): MediaWiki\Maintenance\MaintenanceRunner->run()
#8 /home/tgr/T323958-deploy-newimpact/refreshUserImpactData.php(231): require_once(string)
#9 /srv/mediawiki/multiversion/MWScript.php(120): require_once(string)
#10 {main}
Impact
Notes

Event Timeline

kostajh triaged this task as High priority.Dec 1 2022, 9:22 AM

Seen on the rest.php endpoint on testwiki, as well as when running the maintenance script.

Change 862832 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] DatabaseUserImpactStore: Fix parameter style for upsert keys

https://gerrit.wikimedia.org/r/862832

Change 862355 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] DatabaseUserImpactStore: Fix parameter style for upsert keys

https://gerrit.wikimedia.org/r/862355

Change 862832 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] DatabaseUserImpactStore: Fix parameter style for upsert keys

https://gerrit.wikimedia.org/r/862832

Change 862355 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] DatabaseUserImpactStore: Fix parameter style for upsert keys

https://gerrit.wikimedia.org/r/862355

Mentioned in SAL (#wikimedia-operations) [2022-12-01T14:20:29Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:862355|DatabaseUserImpactStore: Fix parameter style for upsert keys (T324188)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-01T14:21:38Z] <kharlan@deploy1002> kharlan and kharlan: Backport for [[gerrit:862355|DatabaseUserImpactStore: Fix parameter style for upsert keys (T324188)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-01T14:27:54Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:862355|DatabaseUserImpactStore: Fix parameter style for upsert keys (T324188)]] (duration: 07m 25s)