The Download button is provided by the Wikisource extension and is availiable in Book namespaces defined in the $wgProofreadPageBookNamespaces variable (mostly the Main namespace, and sometimes the Translation namespace) :)

pinging @Tpt and @Samwilson

Possibly what we want to do here is something like the following in a Wikisource skinStyles file for Vector-2022:

.mw-indicators {
    padding-top: 12px;
}

Would that be agreeable to everyone? I feel like the whole thing of having a button in the indicator space is a bit strange (but then, there's no obvious other way to do this either, I think).

(I've just noticed that there's no style linting in the Wikisource extension, so I think I'll start by doing that!)

Change 861348 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Wikisource@master] Add stylelint and fix errors

https://gerrit.wikimedia.org/r/861348

Change 861348 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Add stylelint and fix errors

https://gerrit.wikimedia.org/r/861348

Change 861457 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Wikisource@master] Add stylelint to existing grunt 'fix' task

https://gerrit.wikimedia.org/r/861457

Change 861457 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Add stylelint to existing grunt 'fix' task

https://gerrit.wikimedia.org/r/861457

Ideally, shouldn't this be the main action item in the main namespace across all Wikisources for all logged-out users, something displayed next to/instead of Edit, but stronger than that?

@Soda seems like there is an unresolved discussion here:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/ /861348/

Looks resolved to me, but idk. Maybe you just forgot to change status? :)

Maybe, taking advantage of the fact that the fix has not been implemented for two months, it is worth considering whether it would be a better idea to move "<div id="contentSub">" over "<div class="vector-body-before-content" >", as they probably do with javascript on fr ws

In T323847#8503555, @Nux wrote:

@Soda seems like there is an unresolved discussion here:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/ /861348/

Looks resolved to me, but idk. Maybe you just forgot to change status? :)

Yes that conversation was resolved by the followup patch :)

In T323847#8504525, @Zdzislaw wrote:

Maybe, taking advantage of the fact that the fix has not been implemented for two months, it is worth considering whether it would be a better idea to move "<div id="contentSub">" over "<div class="vector-body-before-content" >", as they probably do with javascript on fr ws

After such a change, imho it looks better without the extra padding:

AFAIK this is being added server-side, so there no actual way to change where this is being added atleast from the point of the Wikisource extension. (Also I'm not sure vector-body-before-content is a stable class that is expected to be availiable across all extensions)

In T323847#8423829, @Samwilson wrote:

Possibly what we want to do here is something like the following in a Wikisource skinStyles file for Vector-2022:

.mw-indicators {
    padding-top: 12px;
}

Would that be agreeable to everyone? I feel like the whole thing of having a button in the indicator space is a bit strange (but then, there's no obvious other way to do this either, I think).

(I've just noticed that there's no style linting in the Wikisource extension, so I think I'll start by doing that!)

I do agree on the weirdness of the button in indicator (which I assume is something not a lot of extensions do). Maybe we can have a different design that preserves the relative call-to-action nature/importance of the button ? Alternatively just adding a padding for now seems like a reasonable fix as well :)

There's a similar problem with the Timeless skin:

and with .mw-indicators { margin-top: -1em; }: