Page MenuHomePhabricator

SX Block Template adaptation: Edits are being lost when template is re-edited
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Start a translation for a section (probably a lead section) that contains an adaptable block template.
  2. Proceed to the "Pick a sentence" step to actually translate the content.
  3. Click on the template and then on "Review and edit the translation" button inside the block template adaptation card at the bottom of the screen.
  4. Edit the adapted template by filling in a new template parameter, then click on the blue right arrow to persist that edit.
  5. Click again on the template and try to re-edit it inside the Visual Editor.

Screencast of the issue:

What happens?:
The changes that were made in the previous step (step 4) are lost and the initial adapted template shows up inside the Visual Editor.

What should have happened instead?:
The changes should appear inside the Visual Editor, so that the user can make new changes on top of the previous ones.

Event Timeline

Change 860482 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Fix block template edit to use translated content if exists

https://gerrit.wikimedia.org/r/860482

Change 860482 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Fix block template edit to use translated content if exists

https://gerrit.wikimedia.org/r/860482

Change 867113 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0 20221212

https://gerrit.wikimedia.org/r/867113

Change 867113 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0 20221212

https://gerrit.wikimedia.org/r/867113