Page MenuHomePhabricator

Red link rt-testing regression
Closed, ResolvedPublicBUG REPORT

Description

Some pages report regressions since the merge of the first set of red link patches - for a short list:

enwiki:Hull_to_Scarborough_Line
dewiki:Frédéric Mistral
eswiki:Agustín_Jose_Donado
enwiki:Serreer
viwiki:Quan hệ tình dục
frwiki:Prononciation_de_l'hébreu
enwiki:State religion

There's at least an instance of a link getting rt'd to [[Springhead locomotive works?action=edit&redlink=1|Springhead locomotive works]] (instead of [[Springhead locomotive works]]).

It *might* have something to do with Cite processing - to be investigated anyway. Can't reproduce things out of the rt-testing context yet.

Event Timeline

Reproducer:

isa-wmf@rocinante:~/gitrepo/parsoid$ echo -e "<ref>[[Not_existing_article]]</ref>\n\n{{1x|<references/>}}" | php ./bin/parse.php --wt2wt
<ref>[[Not existing article?action=edit&redlink=1|Not_existing_article]]</ref>

{{1x|<references/>}}

Change 886345 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Hard-code normalization in Cite

https://gerrit.wikimedia.org/r/886345

Change 860636 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] WIP - redlink serialization

https://gerrit.wikimedia.org/r/860636

Change 860636 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove redlink URL parameters

https://gerrit.wikimedia.org/r/860636

Change 886345 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add a test for red links in templated references

https://gerrit.wikimedia.org/r/886345

There's at least an instance of a link getting rt'd to [[Springhead locomotive works?action=edit&redlink=1|Springhead locomotive works]].

Aside from the odd destination, the syntax corruption (internal syntax for what is a full/external URL) reminds me of T322060: Interwiki link with question mark becomes corrupted internal/external link hybrid.

Change 861464 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861464

Change 861464 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861464

Change 861472 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/vendor@wmf/1.40.0-wmf.12] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861472

Change 861472 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.40.0-wmf.12] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861472