Page MenuHomePhabricator
Create Task
Maniphest T321422

Use buildComparison() instead of raw SQL
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Oct 21 2022, 10:50 PM
Tags
Referenced Files
None
Subscribers
Aklapper
Dreamy_Jazz
matmarex

Description

I think that the function Database::buildComparison() (added by me in change 829293) is very cool and should be used instead of raw SQL in more places where we build queries comparing multiple values. This task is to group all the patches for this. (It could be used for simple comparisons too, but in those cases it's more arguable whether it would be an improvement, so I'm not planning mass replacements.)

I replaced some common patterns in MediaWiki core already in these changes, which can serve as examples:

Helpful code search: https://codesearch-beta.wmcloud.org/deployed/?q=^[^\*\/]+\bOR\b&files=\.php$&excludeFiles=&repos= (this just searches for "OR" in uppercase as a separate word, so there are many false positives in these results – the list below is manually filtered)

Details

SubjectRepoBranchLines /-
Use buildComparison() instead of raw SQL in more maintenance scriptsmediawiki/coremaster 22 -30
Use buildComparison() instead of raw SQLmediawiki/extensions/PageAssessmentsmaster 11 -23
Use buildComparison() instead of raw SQLmediawiki/extensions/PageTriagemaster 18 -20
Use buildComparison() instead of raw SQLmediawiki/extensions/Echomaster 5 -4
Use buildComparison() instead of raw SQLmediawiki/extensions/GeoDatamaster 6 -10
Use buildComparison() instead of raw SQLmediawiki/extensions/CheckUsermaster 9 -20
Use database buildComparison() methodmediawiki/extensions/Wikibasemaster 20 -35
Use buildComparison() instead of raw SQL in SpecialWhatLinksHeremediawiki/coremaster 16 -8
Use buildComparison() instead of raw SQL in API list=usercontribsmediawiki/coremaster 17 -20
Use buildComparison() instead of raw SQLmediawiki/extensions/GlobalUsagemaster 15 -15
Use buildComparison() instead of raw SQL in RevisionStoremediawiki/coremaster 14 -14
Use buildComparison() instead of raw SQL in WatchedItemQueryServicemediawiki/coremaster 44 -44
Use buildComparison() instead of raw SQL in API list=randommediawiki/coremaster 8 -4
Use buildComparison() instead of raw SQL in API list=exturlusage, prop=extlinksmediawiki/coremaster 10 -20
Use buildComparison() instead of raw SQL in API prop=linkshere and friendsmediawiki/coremaster 7 -28
Use buildComparison() instead of raw SQL in API list=categorymembersmediawiki/coremaster 6 -8
Use buildComparison() instead of raw SQL in API list=backlinks and friendsmediawiki/coremaster 12 -14
Use buildComparison() instead of raw SQL in CategoryMembershipChangeJobmediawiki/coremaster 4 -3
Use buildComparison() instead of raw SQL in REST APImediawiki/coremaster 20 -15
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Oct 21 2022, 10:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2022, 10:50 PM
matmarex edited projects, added MediaWiki-REST-API, MediaWiki-Action-API, CheckUser, Notifications, FlaggedRevs, GeoData, GlobalUsage, MediaWiki-extensions-PageAssessments, PageTriage, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikimediaMaintenance; removed MediaWiki-extensions-General, MediaWiki-General.Oct 21 2022, 11:12 PM
matmarex updated the task description. (Show Details)
Restricted Application added projects: Growth-Team, Discovery-Search, Community-Tech. · View Herald TranscriptOct 21 2022, 11:12 PM
Maintenance_bot added a project: Wikidata.Oct 21 2022, 11:29 PM
gerritbot added a comment.Oct 21 2022, 11:39 PM

Change 832641 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=backlinks and friends

https://gerrit.wikimedia.org/r/832641

gerritbot added a project: Patch-For-Review.Oct 21 2022, 11:40 PM

Change 845766 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API prop=linkshere and friends

https://gerrit.wikimedia.org/r/845766

gerritbot added a comment.Oct 21 2022, 11:40 PM

Change 845767 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=categorymembers

https://gerrit.wikimedia.org/r/845767

gerritbot added a comment.Oct 21 2022, 11:40 PM

Change 845768 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=exturlusage, prop=extlinks

https://gerrit.wikimedia.org/r/845768

gerritbot added a comment.Oct 21 2022, 11:40 PM

Change 845769 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=random

https://gerrit.wikimedia.org/r/845769

gerritbot added a comment.Oct 21 2022, 11:40 PM

Change 845770 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=usercontribs

https://gerrit.wikimedia.org/r/845770

TheresNoTime subscribed.Oct 21 2022, 11:52 PM
gerritbot added a comment.Oct 21 2022, 11:55 PM

Change 832642 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in REST API

https://gerrit.wikimedia.org/r/832642

gerritbot added a comment.Oct 21 2022, 11:55 PM

Change 845773 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in CategoryMembershipChangeJob

https://gerrit.wikimedia.org/r/845773

gerritbot added a comment.Oct 21 2022, 11:55 PM

Change 845774 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in WatchedItemQueryService

https://gerrit.wikimedia.org/r/845774

gerritbot added a comment.Oct 22 2022, 12:08 AM

Change 845777 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in RevisionStore

https://gerrit.wikimedia.org/r/845777

Dreamy_Jazz subscribed.Oct 22 2022, 11:22 AM

@matmarex are you going to be working on patches for extensions?

matmarex added a comment.Oct 22 2022, 6:48 PM

Yes, but I haven't written any yet, so feel free to help :D I'm not sure when I'll be working on that, it's not really a priority and I don't really want to have 30 patches waiting for review at the same time.

• MPhamWMF moved this task from needs triage to watching / waiting on the Discovery-Search board.Oct 24 2022, 3:37 PM
gerritbot added a comment.Oct 24 2022, 10:03 PM

Change 832642 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in REST API

https://gerrit.wikimedia.org/r/832642

gerritbot added a comment.Oct 24 2022, 10:03 PM

Change 845773 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in CategoryMembershipChangeJob

https://gerrit.wikimedia.org/r/845773

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 24 2022, 11:00 PM
gerritbot added a comment.Oct 25 2022, 12:15 AM

Change 832641 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=backlinks and friends

https://gerrit.wikimedia.org/r/832641

gerritbot added a comment.Oct 25 2022, 12:16 AM

Change 845766 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API prop=linkshere and friends

https://gerrit.wikimedia.org/r/845766

gerritbot added a comment.Oct 25 2022, 12:17 AM

Change 845767 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=categorymembers

https://gerrit.wikimedia.org/r/845767

gerritbot added a comment.Oct 25 2022, 11:42 AM

Change 845768 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=exturlusage, prop=extlinks

https://gerrit.wikimedia.org/r/845768

gerritbot added a comment.Oct 25 2022, 11:43 AM

Change 845769 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=random

https://gerrit.wikimedia.org/r/845769

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 25 2022, 12:00 PM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.Oct 26 2022, 11:38 AM
gerritbot added a comment.Nov 2 2022, 10:11 AM

Change 845774 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in WatchedItemQueryService

https://gerrit.wikimedia.org/r/845774

gerritbot added a comment.Nov 2 2022, 10:12 AM

Change 845777 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in RevisionStore

https://gerrit.wikimedia.org/r/845777

TheresNoTime unsubscribed.Nov 2 2022, 10:13 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Nov 2 2022, 11:00 AM
gerritbot added a comment.Nov 3 2022, 1:54 AM

Change 852286 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/GlobalUsage@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/852286

gerritbot added a comment.Nov 3 2022, 10:43 AM

Change 852286 merged by jenkins-bot:

[mediawiki/extensions/GlobalUsage@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/852286

gerritbot added a comment.Nov 3 2022, 10:45 AM

Change 845770 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in API list=usercontribs

https://gerrit.wikimedia.org/r/845770

gerritbot added a comment.Nov 3 2022, 2:16 PM

Change 852892 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CheckUser@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/852892

gerritbot added a comment.Nov 3 2022, 2:30 PM

Change 852896 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/PageTriage@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/852896

matmarex mentioned this in T322367: WikiExporter::dumpPages() batching/paging logic is wrong in edge cases.Nov 3 2022, 7:20 PM
gerritbot added a comment.Nov 3 2022, 7:31 PM

Change 853001 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in SpecialWhatLinksHere

https://gerrit.wikimedia.org/r/853001

matmarex updated the task description. (Show Details)Nov 3 2022, 7:41 PM
gerritbot added a comment.Nov 4 2022, 4:55 PM

Change 853377 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use database buildComparison() method

https://gerrit.wikimedia.org/r/853377

gerritbot added a comment.Nov 4 2022, 5:01 PM

Change 853001 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in SpecialWhatLinksHere

https://gerrit.wikimedia.org/r/853001

Lucas_Werkmeister_WMDE mentioned this in T322431: [CLIENT] PHP Notice: Undefined offset: 1 and 2 in Wikibase ApiListEntityUsage (wblistentityusage) and ApiPropsEntityUsage (wbentityusage).Nov 4 2022, 5:11 PM
gerritbot added a comment.Nov 4 2022, 7:19 PM

Change 853377 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use database buildComparison() method

https://gerrit.wikimedia.org/r/853377

gerritbot added a comment.Nov 7 2022, 10:28 AM

Change 852892 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/852892

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 7 2022, 10:57 AM
MusikAnimal moved this task from New & TBD Tickets to Following on the Community-Tech board.Nov 7 2022, 3:08 PM
Dreamy_Jazz updated the task description. (Show Details)Nov 8 2022, 10:15 PM
Novem_Linguae moved this task from Backlog to Code Review on the PageTriage board.Nov 10 2022, 2:35 AM
gerritbot added a comment.Nov 15 2022, 11:02 AM

Change 856935 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Use buildComparison() instead of raw SQL in more maintenance scripts

https://gerrit.wikimedia.org/r/856935

gerritbot added a comment.Nov 15 2022, 11:02 AM

Change 856936 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Echo@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/856936

gerritbot added a comment.Nov 15 2022, 11:02 AM

Change 856937 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/GeoData@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/856937

matmarex updated the task description. (Show Details)Nov 15 2022, 11:05 AM
gerritbot added a comment.Nov 15 2022, 3:00 PM

Change 856936 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/856936

gerritbot added a comment.Nov 15 2022, 3:00 PM

Change 856937 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/856937

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.12; 2022-11-28); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 15 2022, 4:00 PM
gerritbot added a comment.Nov 26 2022, 2:14 PM

Change 860968 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/PageAssessments@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/860968

matmarex updated the task description. (Show Details)Nov 26 2022, 2:15 PM
gerritbot added a comment.Nov 30 2022, 9:15 AM

Change 852896 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/852896

kostajh updated the task description. (Show Details)Nov 30 2022, 9:18 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.13; 2022-12-05); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 30 2022, 10:01 AM
gerritbot added a comment.Dec 1 2022, 1:59 AM

Change 860968 merged by jenkins-bot:

[mediawiki/extensions/PageAssessments@master] Use buildComparison() instead of raw SQL

https://gerrit.wikimedia.org/r/860968

gerritbot added a comment.Dec 1 2022, 2:52 PM

Change 856935 merged by jenkins-bot:

[mediawiki/core@master] Use buildComparison() instead of raw SQL in more maintenance scripts

https://gerrit.wikimedia.org/r/856935

matmarex closed this task as Resolved.Dec 1 2022, 3:00 PM
matmarex updated the task description. (Show Details)
Novem_Linguae moved this task from Code Review to Done on the PageTriage board.Dec 11 2022, 8:26 PM
MusikAnimal moved this task from Backlog to Done on the MediaWiki-extensions-PageAssessments board.Apr 5 2023, 2:43 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 5 2023, 3:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits