Page MenuHomePhabricator
Create Task
Maniphest T319037

Remove GEMentorshipUseIsActiveFlag and GERecentChangesUnstarredMenteesFilterEnabled
Closed, ResolvedPublic
Actions

Description

In T318457 and T293182, we added two (temporary) config flags:

  • GEMentorshipUseIsActiveFlag, to control whether the "is mentee active" database flag is used.
  • GERecentChangesUnstarredMenteesFilterEnabled, to control whether the recent changes filters are fixed

Once we have the RC filters working fine in arwiki/enwiki/fawiki, we can safely remove both variables.

Details

SubjectRepoBranchLines /-
Revert "MentorFiltersHooks: Make it possible to disable unstarred filters"mediawiki/extensions/GrowthExperimentsmaster 13 -27
Remove GEMentorshipUseIsActiveFlagmediawiki/extensions/GrowthExperimentsmaster 6 -58
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Sep 30 2022, 3:52 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 30 2022, 3:52 PM
Urbanecm_WMF changed the task status from Open to Stalled.Sep 30 2022, 3:53 PM
Urbanecm_WMF triaged this task as Low priority.
Urbanecm_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.

Pending the implementation (and testing).

Urbanecm_WMF moved this task from New Tasks to Needs Discussion on the GrowthExperiments-Mentorship board.Oct 5 2022, 10:19 AM
MShilova_WMF moved this task from Upcoming Work to Triaged on the Growth-Team board.Nov 7 2022, 6:21 PM
Urbanecm_WMF changed the task status from Stalled to Open.Nov 16 2022, 10:05 PM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Urbanecm_WMF moved this task from Needs Discussion to In Progress on the GrowthExperiments-Mentorship board.
Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 16 2022, 10:32 PM

Change 857790 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Remove GEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/857790

gerritbot added a project: Patch-For-Review.Nov 16 2022, 10:32 PM
Urbanecm_WMF moved this task from In Progress to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 17 2022, 12:21 PM

This can go straight to code review when wmf.12 is branched.

Urbanecm_WMF removed a project: Patch-For-Review.Nov 17 2022, 8:34 PM
Urbanecm_WMF renamed this task from Remove GEMentorshipUseIsActiveFlag to Remove GEMentorshipUseIsActiveFlag and GERecentChangesUnstarredMenteesFilterEnabled.Nov 18 2022, 12:16 AM
Urbanecm_WMF updated the task description. (Show Details)
Restricted Application added a subscriber: Huji. · View Herald TranscriptNov 18 2022, 12:16 AM
Urbanecm_WMF merged a task: T323267: Remove GERecentChangesUnstarredMenteesFilterEnabled flag.Nov 18 2022, 12:16 AM
gerritbot added a comment.Nov 18 2022, 12:16 AM

Change 858300 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Revert "MentorFiltersHooks: Make it possible to disable unstarred filters"

https://gerrit.wikimedia.org/r/858300

gerritbot added a project: Patch-For-Review.Nov 18 2022, 12:16 AM
Urbanecm_WMF changed the task status from Open to In Progress.Dec 1 2022, 6:59 PM
Urbanecm_WMF moved this task from Blocked / Needs work to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 2 2022, 6:16 PM

Change 857790 merged by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] Remove GEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/857790

gerritbot added a comment.Dec 2 2022, 6:16 PM

Change 858300 merged by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] Revert "MentorFiltersHooks: Make it possible to disable unstarred filters"

https://gerrit.wikimedia.org/r/858300

Urbanecm_WMF closed this task as Resolved.Dec 2 2022, 6:41 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 2 2022, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits