Page MenuHomePhabricator

Log when geoshape/geoline requests return empty data
Closed, ResolvedPublic1 Estimated Story Points

Description

To get a better of the current dynamics of failing geoshape/geoline request it would be helpful do have more insights when/where/how often these happen. We assume, that many of these fails are related to failing database request due to out-of-sync database replicas.

Event Timeline

WMDE-Fisch set the point value for this task to 1.Aug 24 2022, 7:58 AM

Change 827536 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/services/kartotherian@master] Log when geoshape/geoline requests return empty data

https://gerrit.wikimedia.org/r/827536

Change 827536 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Log when geoshape/geoline requests return empty data

https://gerrit.wikimedia.org/r/827536

Change 828949 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mapdata@master] [WIP] Log failing promises everywhere

https://gerrit.wikimedia.org/r/828949

Change 828953 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/services/kartotherian@master] [WIP] Log failing promises everywhere

https://gerrit.wikimedia.org/r/828953

@awight, I continued to play around on https://logstash.wikimedia.org/ and the only thing I found are log entries that appear to be about successful calls of the mapdata query API: https://logstash.wikimedia.org/app/dashboards#/view/2aaec610-e0cc-11ec-bb3e-0bc9ce387d88?_g=h@42b0d52&_a=h@d97f21b. They are marked as NOTICE. HTTP status is 200. The only thing that looks suspicious is the user agent: kartotherian/2.0.0 undefined. The undefined at the end is the userAgentContact in kartotherian's lib/geoshapes/index.js. Where does this get lost?

You can tell these are the HTTP requests made from the mapdata lib's DataLoader class back to MediaWiki because of the user agent and the mpdlimit=max. That's something that's set in DataLoader.js.

Another thing that might be related is what's demoed in https://gerrit.wikimedia.org/r/826267. A detailed description is in T315913#8181289.

Change 829227 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/services/kartotherian@master] Don't put "undefined" in the user-agent

https://gerrit.wikimedia.org/r/829227

Change 829227 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Don't put "undefined" in the user-agent

https://gerrit.wikimedia.org/r/829227

Change 828949 merged by jenkins-bot:

[mapdata@master] Log failing promises everywhere

https://gerrit.wikimedia.org/r/828949

Change 831108 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/services/kartotherian@master] Don't put "undefined" in the user-agent

https://gerrit.wikimedia.org/r/831108

Change 828953 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Log failing promises everywhere

https://gerrit.wikimedia.org/r/828953

Change 831108 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Don't put "undefined" in the user-agent

https://gerrit.wikimedia.org/r/831108

thiemowmde claimed this task.