| ECohen_WMDE | |
| Aug 23 2022, 12:09 PM |
| F35485383: Focus square.png | |
| Aug 23 2022, 12:14 PM |
Currently it's possible to use keyboard nav to move around a map (arrow keys) and zoom ( /-) but it's very hard to tell when the map is in focus. We would like to make this more visible.
~ See figma for specifications
We agree to the limitation, that auto-resize does not work when reducing the height.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T338318 Evaluate & improve accessibility of TechWish products | |||
| Open | None | T308320 Improve accessibility for Kartographer | |||
| Resolved | Andrew-WMDE | T315997 Make focus on map more visible when using keyboard nav |
Change 833797 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):
[mediawiki/extensions/Kartographer@master] [POC] Show an outline when the fullscreen map is in focus
@ECohen_WMDE It seems that the map is always focused when opening the fullscreen mode. It's nice to have the keyboard interactions of course, but this means that the blue box is always drawn which seems less nice. Thoughts?
@ECohen_WMDE It seems that the map is always focused when opening the fullscreen mode. It's nice to have the keyboard interactions of course, but this means that the blue box is always drawn which seems less nice. Thoughts?
I don't think it should be visible until the user clicks tab to indicate that they are in keyboard navigation mode. When I click tab currently, the first thing in the tab order is the full screen map. This is when it should be visible, but not before. Is that possible?
Change 840127 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):
[mediawiki/extensions/Kartographer@master] [POC] Show an outline using CSS when the fullscreen map is in focus
The current version of the patch that will be merged does exactly that. So nothing to worry about I would say.
Change 841123 had a related patch set uploaded (by WMDE-Fisch; author: Andrew-WMDE):
[mediawiki/extensions/Kartographer@master] [POC] Show an outline using CSS flex when the fullscreen map is in focus
Change 833797 abandoned by WMDE-Fisch:
[mediawiki/extensions/Kartographer@master] [POC] Show an outline when the fullscreen map is in focus
Reason:
We decided against the pure JS solution.
Change 841123 abandoned by WMDE-Fisch:
[mediawiki/extensions/Kartographer@master] [POC] Show an outline using CSS flex when the fullscreen map is in focus
Reason:
Going with Id1dce7181937fee1ba26a07f61ac889f327b421d. It's less code.
Change 840127 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Show an outline using CSS when the fullscreen map is in focus
Change 843876 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):
[mediawiki/extensions/Kartographer@master] [WIP] Show an outline on the map when using keyboard nav
Change 843876 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Show an outline on the map when using keyboard nav
Lets discuss during sprint review if we also want to remove the frame when the user starts zooming with the mouse wheel. Could be added later then.