Page MenuHomePhabricator
Create Task
Maniphest T315626

[Config Change] Add Clear Affordances to beta feature at partner wikis (desktop)
Closed, ResolvedPublic
Actions

Description

This task represents the work with enabling "Clear Affordances" as a feature within the existing Discussion tools Beta Feature.

Deployment Timing

Tuesday, 27 September 2022

Deployment wikis

  • ar.wiki
  • cs.wiki
  • hu.wiki

Requirements

  • People who meet the criteria below will see the new Reply affordance styling when visiting any Article or User talk pages on desktop:
    • People who have the Discussion tools beta feature enabled
    • People who have the Show discussion activity setting within Special:Preferences#mw-prefsection-editing enabled
    • People accessing ar.wiki, cs.wiki, or hu.wiki using the desktop version of the site

Minimum test case

  1. At the wikis listed in Deployment wikis above, visit Special:Preferences#mw-prefsection-betafeatures
  2. Ensure the Discussion tools Beta Feature is enabled and the Show metadata about each discussion and enable a new page layout. list item appears within it
  3. Visit a User or Article talk page
  4. Verify that all Reply links/buttons appear in the way(s) we defined in T309904
  5. Visit a talk page that is NOT in the User or Article talk namespace and verify that Reply links appear as they did prior to this deployment and the Add topic button T267444 introduces is not visible. Read: talk page sections should continue being styled as they had before today's deployment.

Done

  • Requirements are implemented and verified as having been implemented

Details

SubjectRepoBranchLines /-
Enable DiscussionTools reply button visual enhancements on cswiki huwikioperations/mediawiki-configmaster 2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Aug 18 2022, 11:35 PM
ppelberg mentioned this in T302547: [Usability Improvements] Deploy as Beta Feature at all wikis (desktop).Aug 18 2022, 11:37 PM
ppelberg added a subtask: T314449: Reconsider the amount of whitespace between Topic Container and first comment (desktop).
ppelberg added a subtask: T315581: Topic Containers can cause a blank space to appear atop desktop talk pages.
ppelberg mentioned this in T313453: [SPIKE] Decide whether config is necessary to isolate Clear Affordances to desktop talk pages.Aug 24 2022, 11:33 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Aug 25 2022, 3:34 PM
ppelberg closed subtask T315581: Topic Containers can cause a blank space to appear atop desktop talk pages as Resolved.Sep 13 2022, 4:32 PM
ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.Sep 13 2022, 11:03 PM
ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.
ppelberg mentioned this in T317717: Announce planned Clear Affordances (desktop) Beta Feature deployment at partner wikis.Sep 15 2022, 6:06 PM
ppelberg added a comment.Sep 21 2022, 4:23 PM
NOTE: per T267444#8240301, the scope of this release has been decreased to simply include new styling for the Reply links that appear on talk pages. I've updated the task description accordingly.
ppelberg updated the task description. (Show Details)Sep 21 2022, 4:24 PM
Esanders renamed this task from [Config Change] Enable Clear Affordances as beta feature at partner wikis (desktop) to [Config Change] Add Clear Affordances to beta feature at partner wikis (desktop).Sep 21 2022, 4:55 PM
ppelberg assigned this task to • Whatamidoing-WMF.Sep 22 2022, 12:25 AM

Per what @Whatamidoing-WMF, this deployment can happen as early as Tuesday, 27 September 2022, assuming no blocking issues arise via the conversations T317717 will start.

I'm assigning this ticket over to Sherry for her to confirm no such "blocking" issues emerged before this goes out next week.

ppelberg updated the task description. (Show Details)Sep 22 2022, 12:25 AM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
• Whatamidoing-WMF added a subscriber: DLynch.Sep 26 2022, 5:29 PM

@DLynch, I think we should remove arwiki from this deployment. The word in Arabic is very short, and the [brackets] make it easier to see.

DLynch claimed this task.Sep 27 2022, 2:49 PM
DLynch moved this task from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.
gerritbot added a comment.Sep 27 2022, 3:45 PM

Change 835648 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] Enable DiscussionTools reply button visual enhancements on cswiki huwiki

https://gerrit.wikimedia.org/r/835648

gerritbot added a project: Patch-For-Review.Sep 27 2022, 3:45 PM
gerritbot added a comment.Sep 27 2022, 8:14 PM

Change 835648 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable DiscussionTools reply button visual enhancements on cswiki huwiki

https://gerrit.wikimedia.org/r/835648

Stashbot added a comment.Sep 27 2022, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-27T20:15:21Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:835648|Enable DiscussionTools reply button visual enhancements on cswiki huwiki (T315626)]]

Stashbot added a comment.Sep 27 2022, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-27T20:15:45Z] <samtar@deploy1002> samtar and kemayo: Backport for [[gerrit:835648|Enable DiscussionTools reply button visual enhancements on cswiki huwiki (T315626)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Sep 27 2022, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-27T20:20:20Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:835648|Enable DiscussionTools reply button visual enhancements on cswiki huwiki (T315626)]] (duration: 04m 58s)

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2022, 8:30 PM
DLynch added a comment.Sep 27 2022, 8:47 PM

This went out to just cswiki and huwiki.

DLynch moved this task from Doing to QA on the Editing-team (Kanban Board) board.Sep 28 2022, 2:52 PM
DLynch added a project: Editing QA.
ppelberg closed subtask T314449: Reconsider the amount of whitespace between Topic Container and first comment (desktop) as Resolved.Sep 28 2022, 3:14 PM
ppelberg updated the task description. (Show Details)Oct 11 2022, 5:10 PM
EAkinloose edited projects, added Verified; removed Editing QA.Oct 12 2022, 10:19 AM
EAkinloose subscribed.

Tested on cswiki
✅ Verify that all Reply links/buttons appear in the way(s) we defined in T309904

Screenshot 2022-10-12 at 11.18.07.png (1×3 px, 789 KB)

✅ Visit a talk page that is NOT in the User or Article talk namespace and verify that Reply links appear as they did prior to this deployment and the Add topic button T267444 introduces is not visible.

Screenshot 2022-10-12 at 11.12.52.png (1×1 px, 421 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 12 2022, 10:20 AM
ppelberg closed this task as Resolved.Oct 18 2022, 12:31 AM
• Whatamidoing-WMF closed subtask T317717: Announce planned Clear Affordances (desktop) Beta Feature deployment at partner wikis as Resolved.Dec 5 2022, 5:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits