vendor.git currently requires version 1.4.1 of onoi/message-reporter. This is breaking tests on php8, as you need 1.4.2 for php 8 support
Wikibase says it needs ~1.4, so updating this should be fine.
vendor.git currently requires version 1.4.1 of onoi/message-reporter. This is breaking tests on php8, as you need 1.4.2 for php 8 support
Wikibase says it needs ~1.4, so updating this should be fine.
Subject | Repo | Branch | Lines /- | |
---|---|---|---|---|
Raise onoi/message-reporter to 1.4.2 for PHP 8.0 compat | mediawiki/vendor | master | 50 -57 |
This is hard because the commit that added support for php 8, marked it as no longer supporting php 7.2. And we want to support both in these tests :(
Hmm, i know general practice is to require exact version in vendor.git, but I wonder if this is a case where it would be acceptable to "1.4.2|1.4.1" since both versions are essentially identical, and its just which version of php they are marked as supporting
The "problem" with doing that becomes if/when someone runs composer using a different version of PHP to what was used last time, the version installed may change.
1.4.1 says php: ^5.6.99|^7.0
1.4.2 says php: >=7.3
Change 836846 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/vendor@master] Raise onoi/message-reporter to 1.4.2 for PHP 8.0 compat
Change 836846 merged by jenkins-bot:
[mediawiki/vendor@master] Raise onoi/message-reporter to 1.4.2 for PHP 8.0 compat