Page MenuHomePhabricator

When restoring an old version of a page, the message now incorrectly says the page has been undeleted
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
*The interface informs you that "the page has been undeleted" (see screenshot below)

image.png (294×819 px, 22 KB)

What should have happened instead?:
*As no undeletion action has occurred, this message should simply says that the new revision has been published.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

Xaosflux updated the task description. (Show Details)

This appears to have been caused by T307181

Seems to be primarily this key change (though it would be worth now re-reviewing the rest of the changes with this context)

@@ -1  1 @@
-"postedit-confirmation-restored": "The page has been restored.",
 "postedit-confirmation-restored": "The page has been undeleted.",

@Xaosflux That was my 2, apologies. Would changing postedit-confirmation-restored back to The page has been restored. be sufficient initially? I don't recall the message saying "published" (but then again, I can't recall ever really looking at that popup..)

Change 805833 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/core@master] i18n/en.json: Revert postedit-confirmation-restored change

https://gerrit.wikimedia.org/r/805833

Seems to be primarily this key change (though it would be worth now re-reviewing the rest of the changes with this context)

@@ -1  1 @@
-"postedit-confirmation-restored": "The page has been restored.",
 "postedit-confirmation-restored": "The page has been undeleted.",

@Xaosflux That was my 2, apologies. Would changing postedit-confirmation-restored back to The page has been restored. be sufficient initially? I don't recall the message saying "published" (but then again, I can't recall ever really looking at that popup..)

That seems fine, it can still be a little misleading (say for cases where you load an old version, also make new changes, then publish it) - but its much less misleading then talking about (un)deletion - so the prior behavior is probably the best fix right now -- splitting exact prior revisions restorations from derivative prior revisions publications could be explored elsewhere.

Change 805833 merged by jenkins-bot:

[mediawiki/core@master] i18n/en.json: Revert postedit-confirmation-restored change

https://gerrit.wikimedia.org/r/805833

Xaosflux triaged this task as Medium priority.Jun 15 2022, 6:33 PM

Patch has been merged, is there more to do here or can this task be resolved?

Patch has been merged, is there more to do here or can this task be resolved?

Resolving (thank you for the prod) — will file a task as mentioned above ref. "splitting exact prior revisions restorations from derivative prior revisions publications could be explored elsewhere"