Page MenuHomePhabricator
Create Task
Maniphest T305411

Codex demo CSS should use default theme 'WikimediaUI' design tokens
Closed, ResolvedPublic
Actions

Description

Background

Right now, there's a CSS file for the Codex documentation site that sets some basic styles, like font family and colors.

Goal

Codex documentation should itself make use of the Wikimedia Product design's choices, provided in “WikimediaUI” theme tokens. We need to use the tokens in this file to ensure things like font-family are correct and up-to-date.

In T305411#8031712, @Volker_E wrote:

This should be active as long as we don't have all essential tokens (size/spacing, typography aka font family, size, …, line height, breakpoints) merged. As long as we have non DS design-decision values in the demos, we should keep this open. It's more like an [EPIC] task IMO.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

AnneT created this task.Apr 4 2022, 9:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2022, 9:02 PM
Volker_E added a project: Documentation.Apr 6 2022, 3:56 PM
Volker_E mentioned this in T293127: [EPIC] Design System Foundation: Design and define design tokens.
Volker_E added a parent task: T293127: [EPIC] Design System Foundation: Design and define design tokens.Apr 6 2022, 4:01 PM
• Sarai-WMDE mentioned this in T304566: Update TextInput to meet the Figma designs.Apr 13 2022, 6:51 PM
AnneT added a project: Design-System-Team (Design-System-Sprint).Apr 18 2022, 4:23 PM
AnneT moved this task from Committed to Ready for Development on the Design-System-Team (Design-System-Sprint) board.
AnneT moved this task from Ready for Development to In Development on the Design-System-Team (Design-System-Sprint) board.Apr 18 2022, 5:42 PM
gerritbot added a comment.Apr 18 2022, 6:19 PM

Change 783871 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] docs: Use design tokens within codex-docs custom theme

https://gerrit.wikimedia.org/r/783871

gerritbot added a project: Patch-For-Review.Apr 18 2022, 6:19 PM
AnneT updated the task description. (Show Details)Apr 18 2022, 6:25 PM
gerritbot added a comment.Apr 19 2022, 6:45 PM

Change 783871 merged by jenkins-bot:

[design/codex@main] docs: Use design tokens within codex-docs custom theme

https://gerrit.wikimedia.org/r/783871

AnneT moved this task from In Development to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.Apr 19 2022, 6:49 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 19 2022, 7:31 PM
Volker_E renamed this task from Codex docs theme CSS should use design tokens to Codex docs theme CSS should use default theme 'WikimediaUI' design tokens.Apr 29 2022, 8:49 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Apr 29 2022, 8:51 PM

Change 787815 had a related patch set uploaded (by VolkerE; author: Anne Tomasevich):

[design/codex@main] docs: Set VitePress text color to `color-base`

https://gerrit.wikimedia.org/r/787815

gerritbot added a project: Patch-For-Review.Apr 29 2022, 8:51 PM
gerritbot added a comment.Apr 29 2022, 9:01 PM

Change 787815 merged by jenkins-bot:

[design/codex@main] docs: Set VitePress text color to `color-base`

https://gerrit.wikimedia.org/r/787815

Volker_E added a parent task: T304062: docs: Codex doc site visual design/user experience improvements.Apr 29 2022, 9:08 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2022, 9:30 PM
• STH triaged this task as High priority.May 1 2022, 12:55 PM
• STH changed the task status from Open to In Progress.May 1 2022, 1:23 PM
• STH lowered the priority of this task from High to Medium.
• STH edited projects, added Design-System-Team; removed Design-System-Team (Design-System-Sprint), Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board).
• STH moved this task from Inbox to Up Next on the Design-System-Team board.
• Catrope edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.May 2 2022, 8:53 PM
Volker_E subscribed.Jun 28 2022, 1:54 AM

This should be active as long as we don't have all essential tokens (size/spacing, typography aka font family, size, …, line height, breakpoints) merged. As long as we have non DS design-decision values in the demos, we should keep this open. It's more like an [EPIC] task IMO.

Volker_E edited projects, added Design-System-Team; removed Design-System-Team (Design-System-Sprint).Jun 28 2022, 1:55 AM
• DAbad lowered the priority of this task from Medium to Low.Jul 28 2022, 8:01 PM
gerritbot added a comment.Sep 22 2022, 3:41 AM

Change 833884 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs, tokens: Replace deprecated design tokens

https://gerrit.wikimedia.org/r/833884

gerritbot added a project: Patch-For-Review.Sep 22 2022, 3:41 AM
gerritbot added a comment.Sep 28 2022, 1:19 AM

Change 833884 merged by jenkins-bot:

[design/codex@main] docs, tokens: Replace deprecated design tokens

https://gerrit.wikimedia.org/r/833884

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2022, 1:29 AM
gerritbot added a comment.Sep 30 2022, 7:32 PM

Change 837181 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Replace static `text-decoration` values with Codex tokens

https://gerrit.wikimedia.org/r/837181

gerritbot added a project: Patch-For-Review.Sep 30 2022, 7:32 PM
gerritbot added a comment.Sep 30 2022, 10:17 PM

Change 837181 merged by jenkins-bot:

[design/codex@main] styles, docs: Replace static `text-decoration` values with Codex tokens

https://gerrit.wikimedia.org/r/837181

Volker_E removed a project: Patch-For-Review.Sep 30 2022, 10:57 PM
ldelench_wmf mentioned this in T319246: [SPIKE] Reassess Codex docs site technical implementation.Oct 3 2022, 9:37 PM
gerritbot added a comment.Oct 4 2022, 7:16 AM

Change 838063 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Use `border-radius-base` design token on footer pager cards

https://gerrit.wikimedia.org/r/838063

gerritbot added a project: Patch-For-Review.Oct 4 2022, 7:16 AM
gerritbot added a comment.Oct 24 2022, 11:42 PM

Change 838063 merged by jenkins-bot:

[design/codex@main] docs: Use Card styles (and its design tokens) on footer pager cards

https://gerrit.wikimedia.org/r/838063

gerritbot added a comment.Oct 25 2022, 11:01 PM

Change 849191 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2

https://gerrit.wikimedia.org/r/849191

gerritbot added a comment.Oct 25 2022, 11:35 PM

Change 849191 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2

https://gerrit.wikimedia.org/r/849191

gerritbot added a comment.Nov 8 2022, 9:56 PM

Change 854619 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Replace calculation with spacing token

https://gerrit.wikimedia.org/r/854619

gerritbot added a comment.Nov 9 2022, 2:08 PM

Change 854619 merged by jenkins-bot:

[design/codex@main] docs: Replace calculation with spacing token

https://gerrit.wikimedia.org/r/854619

gerritbot added a comment.Nov 22 2022, 6:58 PM

Change 859597 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0

https://gerrit.wikimedia.org/r/859597

• Catrope updated the task description. (Show Details)Nov 22 2022, 7:11 PM
gerritbot added a comment.Nov 22 2022, 7:23 PM

Change 859597 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0

https://gerrit.wikimedia.org/r/859597

Volker_E renamed this task from Codex docs theme CSS should use default theme 'WikimediaUI' design tokens to Codex demo CSS should use default theme 'WikimediaUI' design tokens.Dec 19 2022, 6:16 PM
ldelench_wmf raised the priority of this task from Low to Medium.Dec 19 2022, 10:45 PM
ldelench_wmf subscribed.

Discussed at Dec 12 refinement: this is important, but does not block T293127

ldelench_wmf removed a parent task: T293127: [EPIC] Design System Foundation: Design and define design tokens.Dec 19 2022, 10:46 PM
gerritbot added a comment.Dec 23 2022, 7:39 AM

Change 871022 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens, styles: Introduce design-first `font-size` tokens

https://gerrit.wikimedia.org/r/871022

gerritbot added a comment.Dec 23 2022, 9:15 PM

Change 871238 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs, tokens: Apply `line-height` tokens everywhere

https://gerrit.wikimedia.org/r/871238

gerritbot added a comment.Jan 5 2023, 10:11 PM

Change 871238 merged by jenkins-bot:

[design/codex@main] docs, tokens: Apply `line-height` tokens everywhere

https://gerrit.wikimedia.org/r/871238

gerritbot added a comment.Jan 10 2023, 11:05 PM

Change 878213 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.4.2 to v0.4.3

https://gerrit.wikimedia.org/r/878213

PatchDemoBot added a comment.Jan 10 2023, 11:13 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/b7ca0fd8f5/w

gerritbot added a comment.Jan 10 2023, 11:44 PM

Change 878213 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.2 to v0.4.3

https://gerrit.wikimedia.org/r/878213

PatchDemoBot added a comment.Jan 12 2023, 7:08 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/b7ca0fd8f5/w/

gerritbot added a comment.Jan 23 2023, 9:21 PM

Change 871022 merged by jenkins-bot:

[design/codex@main] tokens, styles: Introduce design-first `font-size` tokens

https://gerrit.wikimedia.org/r/871022

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 9:31 PM
gerritbot added a comment.Jan 31 2023, 11:42 PM

Change 869852 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/869852

gerritbot added a project: Patch-For-Review.Jan 31 2023, 11:42 PM
gerritbot added a comment.Feb 1 2023, 2:16 AM

Change 885450 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

gerritbot added a comment.Feb 1 2023, 4:12 AM

Change 885450 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

gerritbot added a comment.Feb 11 2023, 4:34 PM

Change 888290 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Refine visual hierarchy and use Codex tokens

https://gerrit.wikimedia.org/r/888290

Volker_E added a comment.Feb 11 2023, 4:42 PM

Above patch is the last one from my perspective for this task. We can open up new tasks (in response to for example VitePress upstream changes).

Volker_E edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.Feb 11 2023, 4:42 PM
Restricted Application raised the priority of this task from Medium to High. · View Herald TranscriptFeb 11 2023, 4:42 PM
gerritbot added a comment.Feb 13 2023, 11:19 PM

Change 888290 merged by jenkins-bot:

[design/codex@main] docs: Refine visual hierarchy and use Codex tokens

https://gerrit.wikimedia.org/r/888290

gerritbot added a comment.Feb 14 2023, 8:02 PM

Change 889216 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Refine visual hierarchy and use design-first heading styles

https://gerrit.wikimedia.org/r/889216

gerritbot added a comment.Feb 14 2023, 8:28 PM

Change 889216 merged by jenkins-bot:

[design/codex@main] docs: Refine visual hierarchy and use design-first heading styles

https://gerrit.wikimedia.org/r/889216

gerritbot added a comment.Feb 14 2023, 9:23 PM

Change 889230 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0

https://gerrit.wikimedia.org/r/889230

PatchDemoBot added a comment.Feb 14 2023, 9:25 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/66d018802f/w

Volker_E claimed this task.Feb 14 2023, 9:50 PM
Volker_E moved this task from Design Sign-Off to Pending Release on the Design-System-Team (Design-System-Sprint) board.
Volker_E removed a project: Patch-For-Review.
Volker_E closed this task as Resolved.Feb 14 2023, 9:57 PM

Skipping design and QTE sign-off for this code-only task. Design sign off for other bits is happening in T325055.
VitePress custom.css is now only using design tokens.

gerritbot added a comment.Feb 14 2023, 9:58 PM

Change 889230 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0

https://gerrit.wikimedia.org/r/889230

PatchDemoBot added a comment.May 10 2023, 9:08 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/66d018802f/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits