Page MenuHomePhabricator

Add a large margin above the "Log out" button
Open, LowPublicFeature

Description

Context: In the new Vector personal tools menu dropdown, the link to "Log out" is directly next to the link to "Contributions".
I click one of those ~daily, and the other ~never.
Misclicks here are extra-frustrating.

Request: I suggest adding a very large empty space above it, to help avoid accidental misclicks. At minimum a whole extra line (32px?), but maybe even more.

Sidenote: This is also a problem in the old Vector, and hundreds of people have grumbled about it over the years. (recent example thread, and semi-related task: T217914: Prevent accidental logouts on desktop Vector skin when using a mobile device).

Example: If I move my mouse 2px down from here, I will accidentally log out.
(After which: (A) I have to log-in to my password manager, and (B) I have to login to my phone and open my 2FA tool. That's 30-60 seconds of frustration and lost-focus.)

image.png (270×256 px, 11 KB)

Event Timeline

@Quiddity thanks for raising this. Though we don't yet have standardized menu components we plan to in the future, so I'm trying to think both of general rules/standardized spacing here, as well as what's appropriate in this specific context. As a first step I think it would be easy to increase the padding around the menu divider element, which is something I see (for example) on the Github user menu:

githubupdated Wikipedia
Screen Shot 2022-01-31 at 12.09.45 PM.png (488×211 px, 28 KB)
Screen Shot 2022-01-31 at 12.09.54 PM.png (404×269 px, 20 KB)

beyond that we get into sort of special-casing territory (which is perhaps appropriate here)... thoughts from a system perspective @Volker_E @bmartinezcalvo ?

@bmartinezcalvo @Sarai-WMDE Ha, funny coincidence. As much as I wasn't sure at the beginning of our conversation, this points more into the direction of having the divider a separate component.
@alexhollender_WMF We've been talking about header/footer treatment of menus. That or, when looking at the Github example with the other groups a grouping or a component way could all three point into the asked for direction. From a UX perspective I'm all in support for fulfilling your ask and tackle @Quiddity's shared problem.

@bmartinezcalvo @Sarai-WMDE Ha, funny coincidence. As much as I wasn't sure at the beginning of our conversation, this points more into the direction of having the divider a separate component.

@Volker_E @Sarai-WMDE yes, I think we should have the divider as separate component to prevent this and other problems.

As a first step I think it would be easy to increase the padding around the menu divider element, which is something I see (for example) on the Github user menu:

@alexhollender_WMF about the options we have to separate more the Logout from the previous item, I think adding more padding between items could be a good solution. What do you think if we add 4 px padding between all items (also adding 4px on top and on bottom of the dropdown menu) instead of adding padding only in Logout? With this solution we could also avoid clicking on other options that we don't want to click on (I think our menu options are currently too close).

Captura de pantalla 2022-02-01 a las 12.19.24.png (990×1 px, 596 KB)

What do you think if we add 4 px padding between all items (also adding 4px on top and on bottom of the dropdown menu) instead of adding padding only in Logout? With this solution we could also avoid clicking on >other options that we don't want to click on (I think our menu options are currently too close).

Captura de pantalla 2022-02-01 a las 12.19.24.png (990×1 px, 596 KB)

@bmartinezcalvo I think that extra space makes sense in this case. There are also other situations where we might want more compact spacing, for example a more basic menu:

Screen Shot 2022-02-01 at 12.10.54 PM.png (535×251 px, 33 KB)

then of course there are other needs of menus, such as section headings, etc. Which is really all to say: we should probably consider all menu needs when making decisions and designing the menu component.

Screen Shot 2022-02-01 at 12.11.07 PM.png (537×240 px, 48 KB)

There are also other situations where we might want more compact spacing, for example a more basic menu:

1. Too much spacing can also be frustrating in other instances!
I made this screenshot (F34939934) about 5 years ago to demonstrate my frustrations with the increased default OOUI menu size. But I understand that it can be helpful for mobile/tablet users (or those with accessibility challenges) to have larger click/tap-targets, so I don't think I ever linked it until now.

Well, it's not only mobile/tablet users, there's also an accessibility aspect to it for users with motor impairments and limitations. That and vast popularity of touch based interfaces both have influenced the 44 x 44 px success requirement.

@alexhollender_WMF We've actually put quite some thought into Menu sections design:

image.png (454×1 px, 61 KB)

ovasileva triaged this task as Medium priority.Apr 1 2022, 2:19 PM
ovasileva moved this task from Not ready to estimate to Groomed on the Web-Team-Backlog board.
ovasileva lowered the priority of this task from Medium to Low.Apr 13 2023, 9:25 PM
ovasileva moved this task from Groomed to Tracking on the Web-Team-Backlog board.