Page MenuHomePhabricator
Create Task
Maniphest T297765

Use tokens in Codex components code
Closed, ResolvedPublic
Actions

Description

Goal

With tokens architecture settled on, the tokens need to be used in Codex current components by

  • replacing WikimediaUI Base,
  • following the token architecture agreements (example: don't use @color tokens outside color: property)
  • expanding existing code to all available Codex tokens (example @box-sizing-base instead of static border-box value), in short tokenize everything according to our architecture guidance

Criteria for Done

Apply Codex tokens to

  • Button
  • Icon
  • Checkbox and
  • Radio with binary-input mixin
  • ToggleSwitch
  • ToggleButton
  • Text input
  • Lookup
  • Combobox
  • Select
    • Option
  • TypeaheadSearch
  • ListTile
    • ListTileLabel
  • Message

With above changes merged, the remaining custom SFC tokens still in place are tackled in T295711

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Dec 15 2021, 9:01 AM
Volker_E mentioned this in T293127: [EPIC] Design System Foundation: Design and define design tokens.
gerritbot added a comment.Dec 15 2021, 9:01 AM

Change 747459 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Icon, tokens: Make Icon component use Codex tokens

https://gerrit.wikimedia.org/r/747459

gerritbot added a project: Patch-For-Review.Dec 15 2021, 9:01 AM

Change 746833 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Make Button component use Codex tokens

https://gerrit.wikimedia.org/r/746833

gerritbot added a comment.Jan 5 2022, 9:16 PM

Change 747459 merged by jenkins-bot:

[design/codex@main] Icon, tokens: Make Icon component use Codex tokens

https://gerrit.wikimedia.org/r/747459

• Catrope mentioned this in rDCOD3359e07070f6: Icon, tokens: Make Icon component use Codex tokens.Jan 5 2022, 9:17 PM
Volker_E updated the task description. (Show Details)Feb 8 2022, 11:12 PM
gerritbot added a comment.Feb 15 2022, 8:10 PM

Change 762943 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] text input, tokens: Make component use Codex tokens

https://gerrit.wikimedia.org/r/762943

Volker_E updated the task description. (Show Details)Feb 16 2022, 11:31 PM
Volker_E removed subscribers: • marcella, • Tonina_Zhelyazkova_WMDE.
Volker_E updated the task description. (Show Details)Feb 16 2022, 11:34 PM
gerritbot added a comment.Feb 17 2022, 5:44 PM

Change 763577 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Message, tokens: Make Message component use Codex tokens

https://gerrit.wikimedia.org/r/763577

gerritbot added a comment.Feb 17 2022, 7:11 PM

Change 762943 merged by jenkins-bot:

[design/codex@main] TextInput, tokens: Make TextInput component use Codex tokens

https://gerrit.wikimedia.org/r/762943

gerritbot added a comment.Feb 18 2022, 1:59 PM

Change 763752 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Select, tokens: Make Select component use Codex tokens

https://gerrit.wikimedia.org/r/763752

Volker_E updated the task description. (Show Details)Feb 21 2022, 9:03 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Feb 21 2022, 9:48 PM

Change 764444 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Lookup, tokens: Make Lookup component use Codex tokens

https://gerrit.wikimedia.org/r/764444

gerritbot added a comment.Feb 21 2022, 11:00 PM

Change 764449 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Combobox, tokens: Make Combobox component use Codex tokens

https://gerrit.wikimedia.org/r/764449

gerritbot added a comment.Feb 21 2022, 11:49 PM

Change 764452 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Checkbox, Radio, tokens: Make binary input components use Codex tokens

https://gerrit.wikimedia.org/r/764452

gerritbot added a comment.Feb 22 2022, 9:09 PM

Change 764444 merged by jenkins-bot:

[design/codex@main] Lookup, tokens: Make Lookup component use Codex tokens

https://gerrit.wikimedia.org/r/764444

Volker_E updated the task description. (Show Details)Feb 27 2022, 12:58 PM
Volker_E edited projects, added Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint); removed Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board).Feb 28 2022, 5:42 PM
Volker_E moved this task from Research to In Development on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
gerritbot added a comment.Feb 28 2022, 5:53 PM

Change 763577 merged by jenkins-bot:

[design/codex@main] Message, tokens: Make Message component use Codex tokens

https://gerrit.wikimedia.org/r/763577

Volker_E updated the task description. (Show Details)Feb 28 2022, 5:56 PM
gerritbot added a comment.Feb 28 2022, 8:39 PM

Change 763752 merged by jenkins-bot:

[design/codex@main] Select, tokens: Make Select component use Codex tokens

https://gerrit.wikimedia.org/r/763752

gerritbot added a comment.Feb 28 2022, 8:39 PM

Change 764449 merged by jenkins-bot:

[design/codex@main] Combobox, tokens: Make Combobox component use Codex tokens

https://gerrit.wikimedia.org/r/764449

gerritbot added a comment.Feb 28 2022, 9:57 PM

Change 746833 merged by jenkins-bot:

[design/codex@main] Button, tokens: Make Button component use Codex tokens

https://gerrit.wikimedia.org/r/746833

Volker_E updated the task description. (Show Details)Mar 1 2022, 11:56 AM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Mar 1 2022, 1:11 PM
gerritbot added a comment.Mar 1 2022, 1:17 PM

Change 767122 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] ListTile, ListTileLabel, tokens: Make ListTile components use Codex tokens

https://gerrit.wikimedia.org/r/767122

gerritbot added a comment.Mar 1 2022, 6:01 PM

Change 767228 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] TextInput, tokens: Use `transition-property-base`

https://gerrit.wikimedia.org/r/767228

gerritbot added a comment.Mar 2 2022, 6:02 PM

Change 767228 merged by jenkins-bot:

[design/codex@main] TextInput, tokens: Use `transition-property-base`

https://gerrit.wikimedia.org/r/767228

gerritbot added a comment.Mar 3 2022, 4:45 PM

Change 767840 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] ToggleSwitch, tokens: Make toggle switch component use Codex tokens

https://gerrit.wikimedia.org/r/767840

Volker_E updated the task description. (Show Details)Mar 3 2022, 4:46 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Mar 3 2022, 5:20 PM
Volker_E updated the task description. (Show Details)Mar 3 2022, 6:55 PM
gerritbot added a comment.Mar 3 2022, 7:20 PM

Change 767867 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] TypeaheadSearch, tokens: Make toggle switch component use Codex tokens

https://gerrit.wikimedia.org/r/767867

gerritbot added a comment.Mar 3 2022, 9:03 PM

Change 767122 merged by jenkins-bot:

[design/codex@main] ListTile, ListTileLabel, tokens: Make ListTile components use Codex tokens

https://gerrit.wikimedia.org/r/767122

gerritbot added a comment.Mar 3 2022, 10:03 PM

Change 767900 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Replace WikimediaUI Base with Codex design tokens reference

https://gerrit.wikimedia.org/r/767900

gerritbot added a comment.Mar 3 2022, 10:18 PM

Change 764452 merged by jenkins-bot:

[design/codex@main] Checkbox, Radio, tokens: Make binary input components use Codex tokens

https://gerrit.wikimedia.org/r/764452

gerritbot added a comment.Mar 3 2022, 10:18 PM

Change 767900 merged by jenkins-bot:

[design/codex@main] docs: Replace WikimediaUI Base with Codex design tokens reference

https://gerrit.wikimedia.org/r/767900

Volker_E updated the task description. (Show Details)Mar 4 2022, 9:30 AM
gerritbot added a comment.Mar 4 2022, 5:50 PM

Change 767840 merged by jenkins-bot:

[design/codex@main] ToggleSwitch, tokens: Make toggle switch component use Codex tokens

https://gerrit.wikimedia.org/r/767840

Volker_E updated the task description. (Show Details)Mar 5 2022, 12:54 PM
Volker_E updated the task description. (Show Details)Mar 6 2022, 5:50 PM
Volker_E updated the task description. (Show Details)Mar 7 2022, 10:58 AM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Mar 11 2022, 10:10 PM

Change 770042 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Removing remaining references to 'WikimediaUI Base' and uninstall

https://gerrit.wikimedia.org/r/770042

gerritbot added a comment.Mar 12 2022, 2:36 AM

Change 767867 merged by jenkins-bot:

[design/codex@main] TypeaheadSearch, tokens: Make typeahead search component use Codex tokens

https://gerrit.wikimedia.org/r/767867

gerritbot added a comment.Mar 12 2022, 2:40 AM

Change 770042 merged by jenkins-bot:

[design/codex@main] Removing remaining references to 'WikimediaUI Base' and uninstall

https://gerrit.wikimedia.org/r/770042

Volker_E closed this task as Resolved.Mar 12 2022, 4:14 AM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Mar 13 2022, 2:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits