| RHo | |
| Nov 17 2021, 1:17 PM |
| F34813075: Screen Shot 2021-12-02 at 11.44.11 AM.png | |
| Dec 2 2021, 7:51 PM |
| F34813116: Screen Shot 2021-12-02 at 11.48.49 AM.png | |
| Dec 2 2021, 7:51 PM |
| F34752661: Screen Shot 2021-11-17 at 2.08.56 PM.png | |
| Nov 17 2021, 10:11 PM |
| F34752663: Screen Shot 2021-11-17 at 2.09.43 PM.png | |
| Nov 17 2021, 10:11 PM |
| F34751936: image.png | |
| Nov 17 2021, 1:17 PM |
| F34751938: image.png | |
| Nov 17 2021, 1:17 PM |
This is a visual change made for the Post-edit dialogs in for Add images that should also apply to the Add links task.
Currently regardless of whether an edit is made when an "Add a link" or "Add a suggested image" structured task is submitted, we show the green Success messageWidget.
This task is to change the message style to the more neutral "Notice" style with Base80 background and Base10 icon when there is no edit made (if all links and image is rejected):
No edit made  | Edit published  |
This was done in T293316: Add an image: minimal quality gate. The changes are now in betalabs.
Add link
Add image
This was done in T293316: Add an image: minimal quality gate. The changes are now in betalabs.
Add link
Add image
Hi @mewoph - sorry I missed this in my notifications but this task is about changing the message style to the Base80 background "Notice" style when there is *no* edit puslished, but it seems the opposite change has been made here where the green success style has been removed from both.
Thanks for the clarifications @RHo! I only checked the rejected state, so I didn't realize the same was happening to accepted state. For this particular task, I'll update the notice style. The copy will be fixed separately in T296929: [Regression] Incorrect "publish": message on Add a link mobile when there is not edit made .
Currently the issue where the notice style was shown instead of success only occurs when wgEditSubmitButtonLabelPublish config is true.
Change 743248 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Post-edit dialog: Show success MessageWidget whenever an edit is made
Change 743248 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Post-edit dialog: Show success MessageWidget whenever an edit is made
