Page MenuHomePhabricator

Turn component-specific (SFC) Less variables into Codex design tokens
Closed, ResolvedPublic7 Estimated Story Points

Description

Background and goal

After identifying and defining tokens in

it's obligatory to move Codex over to exclusively use package design tokens over Single File Components (SFCs) variables definition.

Remaining SFC variables per component to be transformed

Button
All tokenized.

ButtonGroup
All tokenized.

Link
*link* mixin

Card
All tokenized.

Dialog
All tokenized.

Icon
All tokenized.

TextInput
All tokenized.

Checkbox/Radio
*binary-input* mixin
All tokenized.

Lookup
*pending-state* mixin, this should be removed entirely. Non-DS design.

Combobox
All tokenized.

Menu
All tokenized.

MenuItem
All tokenized.

*element-with-menu-expanded.less* mixin, in use in Combobox, Lookup, Select, TypeaheadSearch
All tokenized.

Message
All tokenized.

ProgressBar
All tokenized.

Select
All tokenized.
Note, that background-position: center right @spacing-75 is questionable, but we've got spacing token flexbility in there, which should be satisfying.

Tabs
All tokenized.

Thumbnail
All tokenized. Note that we've got align-items: center; justify-content: center; in style code, but not as SFC vars. Unclear if theming needs would make that useful.

ToggleButton
All tokenized.

ToggleButtonGroup
All tokenized.

ToggleSwitch
translateX not tokenized, but SFC var anyways. And questionable if useful from theming perspective.

TypeaheadSearch
All tokenized.

Details

SubjectRepoBranchLines /-
mediawiki/coremaster 710 -673
mediawiki/coremaster 879 -779
design/codexmain 73 -15
design/codexmain 5 -10
design/codexmain 74 -55
design/codexmain 2 -5
mediawiki/coremaster 911 -813
design/codexmain 112 -28
design/codexmain 0 -3
design/codexmain 21 -30
design/codexmain 2 -6
mediawiki/coremaster 1 K -1 K
design/codexmain 20 -7
design/codexmain 9 -7
design/codexmain 2 -4
design/codexmain 35 -38
mediawiki/coremaster 1 K -1 K
design/codexmain 2 -5
design/codexmain 0 -1
design/codexmain 12 -13
design/codexmain 348 -181
mediawiki/coremaster 30 -25
design/codexmain 5 -6
design/codexmain 0 -2
design/codexmain 5 -7
mediawiki/coremaster 664 -637
design/codexmain 12 -3
mediawiki/coremaster 2 K -1 K
design/codexmain 3 -2
design/codexmain 22 -11
design/codexmain 2 -12
design/codexmain 2 -3
design/codexmain 10 -19
design/codexmain 121 -130
design/codexmain 86 -92
mediawiki/coremaster 1 K -1 K
design/codexmain 0 -1
mediawiki/coremaster 2 K -3 K
design/codexmain 8 -3
mediawiki/coremaster 261 -112
design/codexmain 125 -83
design/codexmain 6 -11
design/codexmain 3 -6
design/codexmain 0 -5
design/codexmain 23 -22
design/codexmain 6 -2
design/codexmain 7 -7
design/codexmain 1 -2
design/codexmain 0 -8
design/codexmain 14 -22
design/codexmain 17 -2
design/codexmain 31 -0
design/codexmain 12 -0
design/codexmain 5 -1
design/codexmain 176 -0
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 871258 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Make `position-offset` token relative & replace offset SFC vars

https://gerrit.wikimedia.org/r/871258

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8c88aa07e6/w/

Change 870706 merged by jenkins-bot:

[design/codex@main] tokens, styles: Add `min-width-medium` to TextInputs and Select

https://gerrit.wikimedia.org/r/870706

Change 878213 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.4.2 to v0.4.3

https://gerrit.wikimedia.org/r/878213

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/b7ca0fd8f5/w

Change 878213 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.2 to v0.4.3

https://gerrit.wikimedia.org/r/878213

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/b7ca0fd8f5/w/

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bf2faf093a/w

Also created a Codex documentation site:
https://patchdemo.wmflabs.org/wikis/bf2faf093a/w/build/codex/docs

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/bf2faf093a/w/

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/595f8966a0/w

Also created a Codex documentation site:
https://patchdemo.wmflabs.org/wikis/595f8966a0/w/build/codex/docs

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/595f8966a0/w/

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/71dd00c269/w

Also created a Codex documentation site:
https://patchdemo.wmflabs.org/wikis/71dd00c269/w/build/codex/docs

Change 869274 merged by jenkins-bot:

[design/codex@main] build, tokens, styles: Introduce simple stylesheet unit transform

https://gerrit.wikimedia.org/r/869274

Change 871022 merged by jenkins-bot:

[design/codex@main] tokens, styles: Introduce design-first `font-size` tokens

https://gerrit.wikimedia.org/r/871022

Change 871258 merged by jenkins-bot:

[design/codex@main] tokens: Make `position-offset` token relative & replace offset SFC vars

https://gerrit.wikimedia.org/r/871258

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/71dd00c269/w/

ldelench_wmf raised the priority of this task from Medium to High.Jan 27 2023, 4:22 PM

Change 885003 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] binary input: Remove obsolete `size-icon-small` token

https://gerrit.wikimedia.org/r/885003

Change 885003 merged by jenkins-bot:

[design/codex@main] binary input: Remove obsolete `size-icon-small` token

https://gerrit.wikimedia.org/r/885003

Change 885266 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] styles, pending state: Replace relative font size SFCs with token

https://gerrit.wikimedia.org/r/885266

Change 885266 merged by jenkins-bot:

[design/codex@main] styles, pending state: Replace relative font size SFCs with token

https://gerrit.wikimedia.org/r/885266

Change 869852 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/869852

Change 885450 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

Change 885450 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

Change 886939 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Tabs, styles: Replace SFC vars with Codex tokens

https://gerrit.wikimedia.org/r/886939

Change 869866 merged by jenkins-bot:

[design/codex@main] ToggleSwitch, tokens: Amend size and replace SFC vars with tokens

https://gerrit.wikimedia.org/r/869866

Change 886939 merged by jenkins-bot:

[design/codex@main] Tabs, styles: Replace SFC vars with Codex tokens

https://gerrit.wikimedia.org/r/886939

Change 888059 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] [WIP] tokens, styles: Add search figure component tokens

https://gerrit.wikimedia.org/r/888059

Change 888060 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Introduce new component tokens for search figure

https://gerrit.wikimedia.org/r/888060

Change 888059 abandoned by VolkerE:

[design/codex@main] [WIP] tokens, styles: Add search figure component tokens

Reason:

superseeded by I025b9c989e6bed

https://gerrit.wikimedia.org/r/888059

Change 888060 merged by jenkins-bot:

[design/codex@main] tokens: Introduce new component tokens for search figure

https://gerrit.wikimedia.org/r/888060

Change 889230 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0

https://gerrit.wikimedia.org/r/889230

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/66d018802f/w

Change 889230 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0

https://gerrit.wikimedia.org/r/889230

Change 896379 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens, styles: Move further SFC tokens to components

https://gerrit.wikimedia.org/r/896379

This comment was removed by Volker_E.

Change 896456 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Button, styles: Use design-first background color tokens for active

https://gerrit.wikimedia.org/r/896456

Change 896379 merged by jenkins-bot:

[design/codex@main] tokens, styles: Move further SFC tokens to components

https://gerrit.wikimedia.org/r/896379

Change 896456 merged by jenkins-bot:

[design/codex@main] Button, styles: Use design-first background color tokens for active

https://gerrit.wikimedia.org/r/896456

Change 897958 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens, styles: Add and apply `z-index` category

https://gerrit.wikimedia.org/r/897958

Change 898855 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Thumbnail, styles: Remove obsolete SFC token

https://gerrit.wikimedia.org/r/898855

Change 898855 merged by jenkins-bot:

[design/codex@main] Thumbnail, styles: Remove obsolete SFC token

https://gerrit.wikimedia.org/r/898855

Change 898895 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v0.6.2 to v0.7.0

https://gerrit.wikimedia.org/r/898895

Change 897958 merged by jenkins-bot:

[design/codex@main] tokens, styles: Add and apply `z-index` category

https://gerrit.wikimedia.org/r/897958

Change 903778 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.7.0 to v0.8.0

https://gerrit.wikimedia.org/r/903778

Change 903778 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.7.0 to v0.8.0

https://gerrit.wikimedia.org/r/903778

Change 918242 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens, binary-input: Replace SFC vars with tokens and add min size

https://gerrit.wikimedia.org/r/918242

Change 918257 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Tabs, styles: Replace SFC vars with tokens

https://gerrit.wikimedia.org/r/918257

Change 918257 merged by jenkins-bot:

[design/codex@main] Tabs, styles: Replace SFC vars with tokens

https://gerrit.wikimedia.org/r/918257

Change 918598 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8333e57f25/w

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8333e57f25/w/

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/66d018802f/w/

Change 918598 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598

Change 918242 merged by jenkins-bot:

[design/codex@main] tokens, binary-input: Replace SFC vars with tokens and add min size

https://gerrit.wikimedia.org/r/918242

Change 921114 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] link, styles: Replace SFC variables with tokens

https://gerrit.wikimedia.org/r/921114

Okay, above ^ is the last piece!

Volker_E set the point value for this task to 7.May 19 2023, 4:31 AM

Change 921114 merged by jenkins-bot:

[design/codex@main] link, styles: Replace SFC variables with tokens

https://gerrit.wikimedia.org/r/921114

Change 922610 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.10.0 to v0.11.0

https://gerrit.wikimedia.org/r/922610

Change 922610 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.10.0 to v0.11.0

https://gerrit.wikimedia.org/r/922610