Page MenuHomePhabricator

Create Figma styles based on design tokens and apply them to the Codex and OOUI Figma libraries
Closed, ResolvedPublic

Description

Background

Tokens missing as part of the components overview design definition. Tokens are the smallest pieces of our Design System. We need to create the tokens as styles in Figma and link them in each component created in our library.

User stories

  • As a designer, I need to be able to reuse design tokens for specification in Figma.
  • As a designer, I need to be able to consult the token specification of system components in Figma.
  • As a designer, I need to be able to apply reusable Figma styles that are aligned with (named after) the system's tokens.

Conditions of Satisfaction

The figma file should reflect the most up to date information

Testing Instructions

Before an official "release" this should be tested with members of both the WMF design and engineering teams.

Acceptance criteria (or Done)

Create styles in Figma:
Apply styles in Figma:
  • Link styles to the Codex library components:
    • Colors
    • Text styles
    • Sizing scale (add the right token in the "Guides" section of each component spec sheet)
    • Opacities (they will be added as color styles in Figma)
    • Box Shadows
    • Border and Border radius (add the right token in the "Guides" section of each component spec sheet)
    • Motion: animation & transition (add the right token in the "Guides" section of each component spec sheet if needed)
    • Grids (update the sizes of grids and breakpoints in the responsive section of each spec sheet)
  • Review the Codex components and make sure they didn't change after apply the new styles (e.g. new text style line height)
  • Link styles to the OOUI library components:
    • Colors
    • Text styles
    • Sizing scale (add the right token in the "Guides" section of each component spec sheet)
    • Opacities (they will be added as color styles in Figma)
    • Box Shadows
    • Border and Border radius (add the right token in the "Guides" section of each component spec sheet)
    • Motion: animation & transition (add the right token in the "Guides" section of each component spec sheet if needed)
    • Grids (update the sizes of grids and breakpoints in the responsive section of each spec sheet)
  • Review components and make sure they didn't change after apply the new styles (e.g. new text style line height)
  • Publish Codex and OOUI libraries with the new styles applied
  • Remove old styles from the icon system library (old styles were there) and OOUI library (we had some old text styles there too)
NOTE: More extensive documentation on what are tokens and how/when to use them will be available in the system's demo page

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Volker_E edited subscribers, added: AAlhazwani-WMF; removed: amin.

Discussed at 25 April triage:
Designers should check off boxes in description when done, so we have shared understanding of how much has been done.

This task can't be done until all set of tokens have been created in Codex. Although some of them were already created in Figma (colors, opacities, shadows and borders), we decided to not publish them until we have them created and merged in Codex (to avoid possible failures or unnecessary updates).

STH triaged this task as Medium priority.Apr 26 2022, 12:41 PM
STH moved this task from Needs Refinement to Up Next on the Design-System-Team board.
STH changed the task status from Open to Stalled.Apr 27 2022, 2:01 PM
STH raised the priority of this task from Medium to High.May 1 2022, 1:19 PM
DAbad lowered the priority of this task from High to Medium.Jul 28 2022, 9:07 PM
DAbad moved this task from Backlog to Up Next on the Design-System-Team board.
DAbad subscribed.

Adding this to backlog to be picked up after we complete token work outlined in https://phabricator.wikimedia.org/T295991

bmartinezcalvo renamed this task from Add tokens to 'Components Overview' Figma file to Add tokens to 'Components Overview' in our Figma libraries.Jul 29 2022, 3:07 PM
bmartinezcalvo updated the task description. (Show Details)
Sarai-WMDE renamed this task from Add tokens to 'Components Overview' in our Figma libraries to Create Figma styles based on design tokens and apply them to the Codex and OOUI Figma libraries.Aug 3 2022, 3:29 PM

@DAbad moving this task to the current sprint. Tokens were already created as styles in Figma and now @Sarai-WMDE and me need to link them in the components from OOUI and Codex libraries.

Sarai-WMDE changed the task status from Stalled to Open.Aug 3 2022, 5:27 PM

Changing status to "Open" since the task is being actively worked on.

bmartinezcalvo changed the task status from Open to Stalled.Aug 16 2022, 2:24 PM

Pending to close Grids T298198 and Typography scale T296998 to update the text styles and add the grids as styles in the Figma library.

bmartinezcalvo changed the task status from Stalled to In Progress.Dec 20 2022, 11:35 AM
bmartinezcalvo moved this task from Incoming to In Development on the Design board.

Moving to the sprint since @Sarai-WMDE and me are applying the right text styles in both OOUI and Codex libraries and we are reviewing and adjusting each component padding in case they changed after apply the new text style line height (from 20px to 22px).

Codex Figma component paddings have been updated in order to maintain the 32px height (Desktop components) after applying the new line height 14/22px. The following component top and bottom paddings have been updated:

  • Buttons
  • Button Groups
  • Combobox
  • Lookup
  • Text Inputs
  • Search
bmartinezcalvo updated the task description. (Show Details)
bmartinezcalvo subscribed.

Assigning this task to @Sarai-WMDE since she will apply the new text styles to OOUI components and she will review their paddings.

ldelench_wmf raised the priority of this task from Medium to High.Jan 27 2023, 4:22 PM

Text styles and padding haven been reviewed in both Codex and OOUI libraries. Assigning the task to me so I can update the grid in the responsive specs in OOUI (last pending item in the Acceptance criteria).

Updated the responsive specs in the OOUI library with the new grid approach. Once the branch is merged we will be able to close this task.

bmartinezcalvo added a subscriber: RHo.

I've updated the OOUI and Codex component's libraries with the new grid approach so solving this task since the acceptance criteria list has been completed.

As commented yesterday with @RHo during one of our meetings, I've created this other task T330274 to evaluate if we want to remove the Responsive specs from the Figma libraries (since at the moment the grid has not been implemented yet and we are not representing in Figma the same as we have in production).