| Urbanecm_WMF | |
| Nov 8 2021, 6:17 PM |
| F34739491: Screen Shot 2021-11-09 at 10.55.15 AM.png | |
| Nov 9 2021, 6:56 PM |
| F34723416: Screen Shot 2021-11-01 at 6.42.12 PM.png | |
| Nov 8 2021, 6:17 PM |
Found by Elena at T280307#7473617.
(2) Multiple clicks on the Pause button produce multiple error messages. Even for a valid input, the multiple clicks will display the error message (much harder to reproduce than with the empty text field).
The submission should only happen a single time for a single dialog, both to not make the API do one thing multiple times, and to avoid multiple error messages displayed.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Urbanecm_WMF | T239234 [EPIC] Newcomer homepage: Mentorship dashboard | |||
| Open | None | T289600 Mentor dashboard: Future release | |||
| Resolved | Urbanecm_WMF | T280307 Mentor dashboard: M2 mentor tools/settings | |||
| Resolved | Urbanecm_WMF | T295309 Mentor tools: Clicking the Pause button causes the submission to happen multiple times |
Change 737707 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] AwaySettingsDialog: Close the dialog before API request finishes
The patch fixes this by closing the away dialog early. But maybe that'll be noticeable on slower connections (where the notification about status change will be significantly delayed)? I can try to prevent the API call being executed more than once with same parameters.
@Etonkovidova Do you have any opinion on this?
Putting to CR, as the submited patch will fix the issue – I'm merely not sure if that's the correct/best way to do it.
Another option could be to return a promise as the step in the OOUI Process returned in AwaySettingsDialog.prototype.getActionProcess that resolves/rejects when the API call is completed. Since the dialog is an OOUI ProcessDialog, the loading state of the dialog will be shown and the buttons are disabled automatically. This might help address the concern that the user could unknowingly close the browser tab before the request completes.
Change 738190 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] AwaySettingsDialog: Return a promise when saving
Another option could be to return a promise as the step in the OOUI Process returned in AwaySettingsDialog.prototype.getActionProcess that resolves/rejects when the API call is completed. Since the dialog is an OOUI ProcessDialog, the loading state of the dialog will be shown and the buttons are disabled automatically. This might help address the concern that the user could unknowingly close the browser tab before the request completes.
That's even better, thanks! {{done}}.
Change 737707 abandoned by Urbanecm:
[mediawiki/extensions/GrowthExperiments@master] AwaySettingsDialog: Close the dialog before API request finishes
Reason:
in favor of 738190
Change 738190 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] AwaySettingsDialog: Return a promise when saving
