Change 715239 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Implement empty screen window

https://gerrit.wikimedia.org/r/715239

Thanks for filling this @Etonkovidova. This should likely be fixed by just following this Figma page.

@OTichonova I think that the screen should be different when mentor just specifies filters that don't match anything, right? Unfortunately, I don't see screen for that in the mockup.

How useful is this message given that there never should be a time when mentors don't see mentees because the data is being collected, except the first day after deployment? OTOH it's not impossible for a mentor to just not have mentees, in which case this message is misleading.

In T289819#7320645, @Tgr wrote:

How useful is this message given that there never should be a time when mentors don't see mentees because the data is being collected, except the first day after deployment?

I don't think that's true. Any mentor who visits their dashboard immediately after signing up (or at least, before the next update finishes) will see zero mentees, because the updating script only processes mentors who are on the list of mentors.

OTOH it's not impossible for a mentor to just not have mentees, in which case this message is misleading.

Not impossible, but I'd say it's unlikely. I just ran the following query on all Growth wikis to get an idea:

WITH mentees_by_mentor AS (
    SELECT
        gemm_mentor_id,
        COUNT(*) AS mentees
    FROM growthexperiments_mentor_mentee
    GROUP BY gemm_mentor_id
)

SELECT
    DATABASE() AS wiki,
    MIN(mentees) AS min_mentees,
    SUM(mentees) AS total_mentees
FROM mentees_by_mentor

This is what I got:

The zeros are very likely caused by mentorship module not being enabled. Apart from that, the lowest number is one. I spot checked that, and it is caused by me mentoring myself via my WMF account.

I expect numbers will get smaller once we deploy to the long tail of small wikis. Good point about new mentors' first day though.

Maybe the text could be rephrased to say something like "You have no mentees. This might be because it takes up to a day for mentee data to be updated"?

It would be possible to differentiate between no results vs. an empty result set (e.g. store last update timestamp as a user preference), but it seems more effort than worth it.

Change 715239 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Implement empty screen window

https://gerrit.wikimedia.org/r/715239

Change 717588 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Update wording for empty screen

https://gerrit.wikimedia.org/r/717588

Change 717588 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Update wording for empty screen

https://gerrit.wikimedia.org/r/717588