Maniphest T286060

Fix the testcase testFederatedPropertiesFailure which we currently skip
Closed, ResolvedPublic
Actions

Description

After Disabling EntityTypesDefinitionFeddyPropsOverrider for EntityTypeDefinitions in WikibaseRepo.ServiceWiring (T285935), ApiEntitySearchHelper isn't wired anymore and that makes the test fail.

Details

	Subject	Repo	Branch	Lines /-
	FP: unskip testFederatedPropertiesFailure for search	mediawiki/extensions/Wikibase	master	1 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T285303 [EPIC] wbformatentities with both local and remote properties
		Resolved		Addshore	T285933 Services that need to become type and source dispatching aware
		Resolved		Rosalie_WMDE	T285935 Disable EntityTypesDefinitionsFeddyPropsOverrider for entity type definitions
		Resolved		Jakob_WMDE	T286060 Fix the testcase testFederatedPropertiesFailure which we currently skip

Event Timeline

Rosalie_WMDE created this task.Jul 2 2021, 3:33 PM

Rosalie_WMDE claimed this task.Jul 6 2021, 10:01 AM

Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Jul 6 2021, 12:23 PM

Rosalie_WMDE moved this task from Doing to To do on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.

Tarrow added a parent task: T285292: Make statement property selector work with both local and remote properties.Jul 7 2021, 9:19 AM

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties; removed Wikibase - Federated Properties (Federation v2 - Sprint 1).Jul 7 2021, 9:19 AM

• Samantha_Alipio_WMDE removed a parent task: T285292: Make statement property selector work with both local and remote properties.Jul 7 2021, 9:49 AM

• Samantha_Alipio_WMDE moved this task from Backlog to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Jul 22 2021, 11:48 AM

Change 708527 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: unskip testFederatedPropertiesFailure for search

https://gerrit.wikimedia.org/r/708527

gerritbot added a project: Patch-For-Review.Jul 28 2021, 1:37 PM

Jakob_WMDE claimed this task.Jul 28 2021, 1:37 PM

Jakob_WMDE moved this task from Prioritized backlog (aka Ready to pick up) to Federation v2 - Sprint 3 on the Wikibase - Federated Properties board.Jul 28 2021, 1:44 PM

Jakob_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 3); removed Wikibase - Federated Properties.

Jakob_WMDE moved this task from To do to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.

Change 708527 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: unskip testFederatedPropertiesFailure for search

https://gerrit.wikimedia.org/r/708527

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 28 2021, 3:16 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 28 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2021, 4:10 PM

Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM