I am not aware of any good reason why we hide these. Probably just needs design and product focus.

The Wikitech shell account name field probably comes from MediaWiki-extensions-OpenStackManager. The other two are core fields.

Change 701626 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/OpenStackManager@master] Add placeholder for shell username field

https://gerrit.wikimedia.org/r/701626

Change 701626 merged by jenkins-bot:

[mediawiki/extensions/OpenStackManager@master] Add placeholder for shell username field

https://gerrit.wikimedia.org/r/701626

Quoting myself from T335516: Do not hide labels in mobile Log in / Sign up forms:

Hiding form labels and leaving placeholders is a bad accessibility practice: placeholders can be hard to remember, and people can fill out information in steps, especially on registration forms, and in case where they have filled in something already, they cannot see what field it was in a form that does not have labels at the top of the form. Modern Codex inputs do not feature this ‘feature’, and neither did OOUI inputs, and this seems like a holdover from a MediaWiki UI era that can be safely removed without much problem.

Change 933628 had a related patch set uploaded (by Saint Johann; author: Saint Johann):

[mediawiki/skins/MinervaNeue@master] Do not hide placeholders in UserLogin form

https://gerrit.wikimedia.org/r/933628

Test wiki created on Patch demo by Stjn using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c3ffc42dcb/w

‘Real name’ field is displayed in patchdemo wiki now, but Wikimedia websites I have tested this CSS with do not have that field since it is disabled via https://noc.wikimedia.org/conf/highlight.php?file=CommonSettings.php

$wgHiddenPrefs[] = 'realname';

Should this misalignment also be fixed? (Present before the patch just so I’m clear.)

Change 933621 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Login page: Show input labels on mobile devices, use notice box

https://gerrit.wikimedia.org/r/933621

Hey design systems team this came up as part of switching the login/signup forms to Codex: T182050 - is there any reason to keep hiding field names in the mobile view like so:

Proposal is something like:

This is an accessibility problem, so please do not remove the relevant tag.

For the reference, my Gerrit patch currently would do this (which seems like an acceptable and accessible way to fix the problem while Codex conversion is underway):

I don't think this is a duplicate of T335516: Do not hide labels in mobile Log in / Sign up forms. This task is about some fields not appearing at all on Minerva, or appearing as an empty inputbox without any indication of what it is for.

Why is this a parent task to T182050: Remove all mediawiki.ui components and libraries in favor of Codex? That feels like a pretty distinct effort as opposed to a quick change that can be done to address the form field labels not showing.

In T285398#8970161, @Jdlrobson wrote:

Hey design systems team this came up as part of switching the login/signup forms to Codex: T182050 - is there any reason to keep hiding field names in the mobile view like so:

No I don't think so, but I'll let @bmartinezcalvo weigh in here.

In T285398#8970190, @stjn wrote:

For the reference, my Gerrit patch currently would do this (which seems like an acceptable and accessible way to fix the problem while Codex conversion is underway):

This looks better to me.

All that being said, I agree with @Tgr that the task description makes this out to be about the sign up form, not the login form...

Both (Special:UserLogin/Special:CreateAccount) are using the same components/styles JFYI. While you can theoretically target one but not the other, that doesn’t seem like the best thing to do.

In T285398#8976620, @stjn wrote:

Both (Special:UserLogin/Special:CreateAccount) are using the same components/styles JFYI. While you can theoretically target one but not the other, that doesn’t seem like the best thing to do.

Oh I see, sorry, I didn't realize the patch addressed both.

In T285398#8976615, @CCiufo-WMF wrote:

Why is this a parent task to T182050: Remove all mediawiki.ui components and libraries in favor of Codex? That feels like a pretty distinct effort as opposed to a quick change that can be done to address the form field labels not showing.

In T285398#8970161, @Jdlrobson wrote:

Hey design systems team this came up as part of switching the login/signup forms to Codex: T182050 - is there any reason to keep hiding field names in the mobile view like so:

No I don't think so, but I'll let @bmartinezcalvo weigh in here.

I'm not sure why labels were hidden in the mobile login (I guess to save vertical space), but I agree for scannability and accessibility reasons it's better to keep them visible.

In T285398#8970190, @stjn wrote:

For the reference, my Gerrit patch currently would do this (which seems like an acceptable and accessible way to fix the problem while Codex conversion is underway):

This looks better to me.

All that being said, I agree with @Tgr that the task description makes this out to be about the sign up form, not the login form...

Yes, it looks better with the labels visible. But keep in mind that the new Codex Field component uses the label with Bold style as default. This decision was taken to make the form items more scannable in long forms.

I can add bold to mobile version if needed in my patch, but keep in mind that there is a separate Codex conversion patch in https://gerrit.wikimedia.org/r/c/mediawiki/core/ /919361/ so maybe it is best to do those changes there instead and this can be just about showing the labels after so many years of hiding them.

In T285398#8985061, @stjn wrote:

I can add bold to mobile version if needed in my patch, but keep in mind that there is a separate Codex conversion patch in https://gerrit.wikimedia.org/r/c/mediawiki/core/ /919361/ so maybe it is best to do those changes there instead and this can be just about showing the labels after so many years of hiding them.

I agree with this. If the plan is to move to Codex in a separate patch, I wouldn't worry too much about the visual consistency with your patch.

Change 933628 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Do not hide placeholders in UserLogin form in Minerva skin

https://gerrit.wikimedia.org/r/933628

While above patch is fixed, this issue is not fixed. The patch merged means all the code now lives inside MediaWiki core.

The patch https://gerrit.wikimedia.org/r/c/933621 still needs to be reviewed to address this issue, once we've agreed it's an issue.

In case it was missed:

In T285398#8984919, @bmartinezcalvo wrote:

I'm not sure why labels were hidden in the mobile login (I guess to save vertical space), but I agree for scannability and accessibility reasons it's better to keep them visible.

(or is someone else needed for this?)

(or is someone else needed for this?)

My understanding is this task @CCiufo-WMF and Design-System-Team will pick this up when they have time to schedule a code review (right now they are quite busy with other initiatives and are missing a few team members due to vacations).

Change 933621 abandoned by Jdlrobson:

[mediawiki/core@master] Login page: Show input labels on mobile devices

Reason:

Not working on this, but feel free to restore it when you've had a chance to discuss this and schedule a code review.

https://gerrit.wikimedia.org/r/933621

(Is there anything preventing the other patch from being merged if this patch was abandoned? I don’t see any objections from Design Systems team on this.)

Can you clarify what is the "other" patch? I don't see any other patches waiting for review. (This task for a bit messed up, maybe I shouldn't have merged them.)

This one: https://gerrit.wikimedia.org/r/c/933628

Well, it's merged :) Was it reverted or something?

Huh, my bad, sorry!

Beta version still has label hiding though: https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:UserLogin&returnto=Main Page

In T285398#9054655, @matmarex wrote:

Well, it's merged :) Was it reverted or something?

Kind of. On 10 July 2023, the Minerva patch merged which removes the display: none; statements that hid the input labels on mobile viewports:

In T285398#9003541, @gerritbot wrote:

Change 933628 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Do not hide placeholders in UserLogin form in Minerva skin

https://gerrit.wikimedia.org/r/933628

But, 48 hours earlier on 7 July 2023, this patch also merged, which re-introduced the same CSS in MediaWiki core under an effectively mobile-specific @media rule.

In T182050#8997571, @gerritbot wrote:

Change 919361 merged by jenkins-bot:

[mediawiki/core@master] Login page: Use Codex CSS components

https://gerrit.wikimedia.org/r/919361

The pending patch is indeed https://gerrit.wikimedia.org/r/c/mediawiki/core/ /933621, however this was abandoned on 28 July 2023 stating:

Change 933621 abandoned:

Reason:

Not working on this, but feel free to restore it when you've had a chance to discuss this and schedule a code review.

As I understand it, both @CCiufo-WMF and @bmartinezcalvo from the Design team have indicated a month ago that these are fine to re-instate:

In T285398#8984919, @bmartinezcalvo wrote:

In T285398#8970161, @Jdlrobson wrote:

[…] is there any reason to keep hiding field names in the mobile view like so: F37121481 […]

In T285398#8976615, @CCiufo-WMF wrote:

No I don't think so, but I'll let @bmartinezcalvo weigh in here.

I'm not sure why labels were hidden in the mobile login (I guess to save vertical space), but I agree for scannability and accessibility reasons it's better to keep them visible.

In T285398#8970190, @stjn wrote:

[…] This looks better to me. […]

Yes, it looks better with the labels visible. But keep in mind that the new Codex Field component uses the label with Bold style as default. This decision was taken to make the form items more scannable in long forms.

Is anything else needed for a small interative improvement to make the labels visible again?

Change 933621 restored by Krinkle:

[mediawiki/core@master] Login page: Show input labels on mobile devices

https://gerrit.wikimedia.org/r/933621

Test wiki created on Patch demo by Krinkle using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/28e7e00f50/w

Test wiki created on Patch demo by Krinkle using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d40ca84da9/w

Test wiki on Patch demo by Krinkle using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/28e7e00f50/w/

Comparison:

• Before (vector): https://patchdemo.wmflabs.org/wikis/22e992fda4/wiki/Special:UserLogin
• After (vector): https://patchdemo.wmflabs.org/wikis/d40ca84da9/wiki/Special:UserLogin
• Before (minerva): https://patchdemo.wmflabs.org/wikis/22e992fda4/wiki/Special:UserLogin?useskin=minerva
• After (minerva): https://patchdemo.wmflabs.org/wikis/d40ca84da9/wiki/Special:UserLogin?useskin=minerva

	Before	After
Vector, wide
Minverva, wide

Identical.

Vector, narrow
Minerva, narrow

• Labels now visible.
• "Keep me logged in" option no longer broken.
• Input field no longer has a custom height or lack of spacing.
• Unchanged: Input field keeps the fluid width feature of matching the width of narrow screens.

I think one concern here was the sign-up page on very small viewports like original iPhone.
The primary button disappears wide below the fold. This should probably be revisited now how much of an impact or any impact at all the visible labels would make on sign-up numbers.
Also we should revisit the placeholders on at least the second group of inputs, they are worthless and distracting for the users in my opinion with labels shown.

In T285398#9009744, @Jdlrobson wrote:

(or is someone else needed for this?)

My understanding is this task @CCiufo-WMF and Design-System-Team will pick this up when they have time to schedule a code review (right now they are quite busy with other initiatives and are missing a few team members due to vacations).

I'm sorry, I missed this as a specific ask for code review.

In T285398#9053319, @stjn wrote:

(Is there anything preventing the other patch from being merged if this patch was abandoned? I don’t see any objections from Design Systems team on this.)

Yes, we agree the design changes here are a good thing. Showing the input labels aligns with our guidelines and best practices from accessibility and design consistency perspectives.

In T285398#9095172, @Volker_E wrote:

I think one concern here was the sign-up page on very small viewports like original iPhone.
The primary button disappears wide below the fold. This should probably be revisited now how much of an impact or any impact at all the visible labels would make on sign-up numbers.

I think this is a question for @ovasileva and/or @KStoller-WMF. Design-System-Team can review the changes from a design (and best use of Codex) perspective, but I think whoever owns the product implications of the change should be responsible for merging.

In T285398#9095172, @Volker_E wrote:

Also we should revisit the placeholders on at least the second group of inputs, they are worthless and distracting for the users in my opinion with labels shown.

See T51018: Remove placeholder text or labels from login form (Special:UserLogin) inputs

Change 933621 merged by jenkins-bot:

[mediawiki/core@master] Login page: Show input labels on mobile devices

https://gerrit.wikimedia.org/r/933621

I was a little concerned this got merged without any follow up given the concern raised in T285398#9095172 and @CCiufo-WMF 's comment in T285398#9097389 so I took a look at the data. While I'm sympathetic with the idea of being bold, particularly in the case of a lack of ownership, I do think as staff members we have a duty to lead by example and check we are not impacting our key metrics.

This looks like it was deployed in wmf24. Using the query SELECT month, day, count(*) from event.serversideaccountcreation where year = 2023 AND ( month = 9 or month = 8 ) AND wiki = 'enwiki' AND event.displayMobile = true group by month, day on https://superset.wikimedia.org/superset/sqllab/ I have confirmed that there was no abnormal change in account sign ups.

@Jdlrobson you have to fix access permissions for the file

@stjn that bug is still not fixed ?!😭 (done)

Test wiki on Patch demo by Stjn using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c3ffc42dcb/w/

Test wiki on Patch demo by Krinkle using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d40ca84da9/w/