Page MenuHomePhabricator

New translation: Confirm translation
Closed, ResolvedPublic

Description

As part of the "new translation" entry point (T241590), when an article is selected to translate (either through search, suggestions or an external link) a confirmation step is shown.

The current design used in Content Translation has been updated to polish visual aspects and avoid presenting the target article existence as a warning (since now it can be expanded).

New translation - Confirm.png (768×1 px, 374 KB)
New translation - Confirm Dimensions.png (768×1 px, 256 KB)

Additional considerations:

  • The action and messages will be different depending on the sections available. This is covered in a separate ticket: T276435: New translation: adapt the confirmation step depending on the sections available
  • Image crop. Since article images have a different aspect ratio and the proposed design displays the images filling the background, the resulting crop cannot be ideal in all cases. A simple adjustment to consider is to place the background image top at 33% (instead of 50%) to focus images with a vertical aspect ratio on the upper third. This helps people-related images to fit better.
  • Image pixelation. If the image resolution is lower than the required to fill the area, the placeholder can be used instead (i.e., as if the article had no image).

On desktop this will be presented as a modal dialog (max-width: 535px) over the dashboard:

New translation - Confirm desktop.png (768×1 px, 347 KB)

(responsive adjustments for desktop can be postponed, info is here for context in case it is useful)

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedngkountas
OpenNone
Resolvedngkountas
Resolvedngkountas
ResolvedBUG REPORTngkountas
Resolvedngkountas
Resolvedngkountas
Resolvedsanthosh
Resolvedngkountas
Resolvedsanthosh
OpenNone
Resolvedngkountas
Resolvedngkountas
Resolvedngkountas
Resolvedsanthosh
Resolvedngkountas
ResolvedPginer-WMF
OpenNone
ResolvedBUG REPORTngkountas
Resolvedsanthosh
DeclinedNone
ResolvedPginer-WMF
Resolvedngkountas
OpenNone
OpenNone
Resolvedngkountas
ResolvedBUG REPORTngkountas
Resolvedngkountas
Resolvedngkountas
ResolvedWangombe
OpenNone
Resolvedngkountas
Resolvedngkountas
Resolvedngkountas
ResolvedWangombe
ResolvedBUG REPORTPginer-WMF
Resolvedngkountas
OpenNone
OpenNone
Resolvedngkountas
OpenNone

Event Timeline

Pginer-WMF triaged this task as Medium priority.Mar 2 2021, 1:00 PM
Pginer-WMF created this task.

There are a couple minor details related to the "open" icons that may need adjustment (I'll create separate follow-up tickets for these):

  1. The option to open the selected article is only accessible when taping the small icon next to it. The whole (title including the icon) should be tappable instead.
  2. The open icon showing at the right side of the "Available in X" label is currently opening in the same browser tab. It should open on a new tab to prevent losing the context for the user.

test.m.wikipedia.org_wiki_Special_ContentTranslation(iPhone 6_7_8) (3).png (1×750 px, 114 KB)