Make PHPCS enforce old style arrays in PHPVersionCheck.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jan 30 2021, 12:23 AM

Description

For legacy reasons (and to try and keep it working on ooold PHP versions), we don't want PHPVersionCheck.php to use [] arrays, we want array()

Details

	Subject	Repo	Branch	Lines /-
	PHPVersionCheck: Enable Generic.Arrays.DisallowShortArraySyntax	mediawiki/core	master	9 -0

Customize query in gerrit

Event Timeline

Reedy created this task.Jan 30 2021, 12:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2021, 12:23 AM

Reedy triaged this task as Lowest priority.Jan 30 2021, 12:23 AM

There is a sniff for this Generic.Arrays.DisallowShortArraySyntax.

Just need to enable/whatever

Change 660058 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] PHPVersionCheck: phpcs:enable Generic.Arrays.DisallowShortArraySyntax

https://gerrit.wikimedia.org/r/660058

gerritbot added a project: Patch-For-Review.Jan 30 2021, 12:30 AM

Change 660058 merged by jenkins-bot:
[mediawiki/core@master] PHPVersionCheck: Enable Generic.Arrays.DisallowShortArraySyntax

https://gerrit.wikimedia.org/r/660058

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2021, 2:10 AM

Krinkle awarded a token.Jan 30 2021, 2:11 AM

Reedy closed this task as Resolved.Jan 30 2021, 2:18 AM

Reedy claimed this task.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 30 2021, 3:00 AM

Make PHPCS enforce old style arrays in PHPVersionCheck.phpClosed, ResolvedPublicActions

Description

Details

Event Timeline

Make PHPCS enforce old style arrays in PHPVersionCheck.php
Closed, ResolvedPublic
Actions