Description

Reported by @BrandonXLF on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SyntaxHighlight_GeSHi/ /653609/1#message-b88df1699c057bde874103460ece9321841c2bfc:

This change causes any floating elements beside the syntaxhighlight block to have unclickable portions where the syntaxhighlight block is stacked over the floating element due to the position: relative;. For example, the links in the navbox next to the syntaxhighlight block at https://www.mediawiki.org/wiki/OOUI/Widgets/Icons,_Indicators,_and_Labels are unclickable.

	Subject	Repo	Branch	Lines /-
	Move position:relative to inner wrapper	mediawiki/extensions/SyntaxHighlight_GeSHi	wmf/1.36.0-wmf.27	5 -1
	Move position:relative to inner wrapper	mediawiki/extensions/SyntaxHighlight_GeSHi	master	5 -1

Event Timeline

Esanders created this task.Jan 25 2021, 2:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2021, 2:39 PM

Change 658315 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/658315

gerritbot added a project: Patch-For-Review.Jan 25 2021, 2:43 PM

T104540 is related to this (100% width containers overlapping floats)

Esanders updated the task description. (Show Details)Jan 25 2021, 2:48 PM

Change 658315 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/658315

Jdforrester-WMF closed this task as Resolved.Jan 25 2021, 10:57 PM

Jdforrester-WMF assigned this task to Esanders.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 25 2021, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2021, 11:10 PM

Pcoombe merged a task: T271641: Unable to click links inside an infobox that floats next to a syntax highlight region.Jan 31 2021, 1:15 PM

Pcoombe added subscribers: Ciencia_Al_Poder, Pcoombe.

matmarex merged a task: T273995: Links on float-elements are not clickable when horizontally aligned with a syntaxhighlight tag.Feb 5 2021, 6:49 PM

matmarex added subscribers: Seb35, matmarex.

This is an annoying issue (as evidenced by the duplicates) and the scheduled deployments have been stuck for two weeks now (T271343), so I'm going to backport the fix.

Change 662668 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@wmf/1.36.0-wmf.27] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/662668

gerritbot added a project: Patch-For-Review.Feb 8 2021, 12:41 PM

Change 662668 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@wmf/1.36.0-wmf.27] Move position:relative to inner wrapper

https://gerrit.wikimedia.org/r/662668

Mentioned in SAL (#wikimedia-operations) [2021-02-08T13:09:48Z] <ladsgroup@deploy1001> Synchronized php-1.36.0-wmf.27/extensions/SyntaxHighlight_GeSHi/modules/pygments.wrapper.less: [[gerrit:662668|Move position:relative to inner wrapper]] (T272853) (duration: 01m 08s)

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2021, 1:10 PM

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.27; 2021-01-19); removed MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Feb 8 2021, 2:00 PM

Syntaxhighlight block can make floated items unclickable
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

	F34022441: image.png
	Jan 25 2021, 2:48 PM

Syntaxhighlight block can make floated items unclickableClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Syntaxhighlight block can make floated items unclickable
Closed, ResolvedPublic
Actions