Page MenuHomePhabricator

[Regression pre-wmf.28] Comments are getting added in wrong order
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Open this page: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:RYasmeen_(WMF)/sandbox
  1. Reply to the first comment

Observed Result:

The newly added reply is getting added before the previous reply instead of after.

Screen Shot 2021-01-22 at 12.23.41 PM.png (358×1 px, 101 KB)

Event Timeline

Update: This is happening only when replying to the first comment of that page it seems. Also the highlight is appearing in an unexpected position.

Regression caused by ae920b831f117c0ad4b5e29c006188cda46ca09f. Looks like we need to have different treatment for <link> nodes representing TemplateStyles, and <link> nodes representing categories.

Change 658483 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Handle category links at ends of comments affecting indentation

https://gerrit.wikimedia.org/r/658483

Change 658483 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Handle category links at ends of comments affecting indentation

https://gerrit.wikimedia.org/r/658483