Page MenuHomePhabricator
Create Task
Maniphest T272579

Update Wikibase diff marker generation
Closed, ResolvedPublic
Actions

Description

MediaWiki changed the way it generates diff markers (“ ”, “-”) with T192526: Diff-view: indicators should not be copied on copy-and-paste (compare EntitySchema test update). We should update the markers Wikibase generates accordingly.

See also T272488: Update EntitySchema diff marker generation. (In all likelihood, this is a very straightforward code change.)

Details

SubjectRepoBranchLines /-
Update diff tests for Wikibase changemediawiki/extensions/WikibaseLexememaster 16 -24
Temporarily disable diff testsmediawiki/extensions/WikibaseLexememaster 8 -0
Update diff HTML to match MediaWikimediawiki/extensions/Wikibasemaster 36 -36
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 21 2021, 10:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2021, 10:30 AM
• LloydDesignFitOut updated the task description. (Show Details)Jan 21 2021, 12:36 PM
Peachey88 updated the task description. (Show Details)Jan 21 2021, 1:05 PM
gerritbot added a comment.Jan 21 2021, 4:54 PM

Change 657640 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update diff HTML to match MediaWiki

https://gerrit.wikimedia.org/r/657640

gerritbot added a project: Patch-For-Review.Jan 21 2021, 4:54 PM
Lucas_Werkmeister_WMDE added a comment.Jan 21 2021, 5:45 PM

Okay, it’s not quite as straightforward because WikibaseLexeme has tests on that HTML as well.

gerritbot added a comment.Jan 28 2021, 5:10 PM

Change 659333 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Temporarily disable diff tests

https://gerrit.wikimedia.org/r/659333

gerritbot added a comment.Jan 28 2021, 5:10 PM

Change 659334 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update diff tests for Wikibase change

https://gerrit.wikimedia.org/r/659334

gerritbot added a comment.Jan 28 2021, 8:07 PM

Change 659333 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Temporarily disable diff tests

https://gerrit.wikimedia.org/r/659333

gerritbot added a comment.Jan 28 2021, 8:07 PM

Change 657640 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update diff HTML to match MediaWiki

https://gerrit.wikimedia.org/r/657640

gerritbot added a comment.Jan 28 2021, 8:07 PM

Change 659334 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Update diff tests for Wikibase change

https://gerrit.wikimedia.org/r/659334

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2021, 8:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 28 2021, 9:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 29 2021, 3:37 PM
Lucas_Werkmeister_WMDE claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits