CentralAuthUtils should use dependency injection
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	taavi
	Dec 25 2020, 7:26 PM

Description

CentralAuthUtils is currently full of static methods calling MediaWikiServices::getInstance()... let's move that to a DI-able class and inject the necessary services?

also naming suggestings for the new class are welcome... CentralAuthUtilities? CentralAuthServices?

Details

	Subject	Repo	Branch	Lines /-
	Add injectable CentralAuthUtilityService to replace CentralAuthUtils	mediawiki/extensions/CentralAuth	master	603 -316

Customize query in gerrit

Related Objects

Mentioned In: T288084: Split CentralAuthUtilityService into multiple smaller services
T273296: Some administrators can no longer add/remove users from the autochecked/editor user groups
T272801: Remove CentralAuthUtils after removing all uses

Event Timeline

taavi created this task.Dec 25 2020, 7:26 PM

Restricted Application added a project: User-Majavah. · View Herald TranscriptDec 25 2020, 7:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

taavi moved this task from Unsorted to Working on on the User-Majavah board.Dec 25 2020, 8:04 PM

Change 651945 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/CentralAuth@master] [WIP] Add DI-friendly CentralAuthServices instead of CentralAuthUtils

https://gerrit.wikimedia.org/r/651945

gerritbot added a project: Patch-For-Review.Dec 25 2020, 8:14 PM

taavi moved this task from Working on to Pending review on the User-Majavah board.Dec 27 2020, 1:47 PM

Change 651945 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Add injectable CentralAuthUtilityService to replace CentralAuthUtils

https://gerrit.wikimedia.org/r/651945

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2021, 9:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 23 2021, 10:00 PM

taavi closed this task as Resolved.Jan 24 2021, 8:29 AM

taavi mentioned this in T272801: Remove CentralAuthUtils after removing all uses.Jan 24 2021, 12:58 PM

• Pchelolo mentioned this in T273296: Some administrators can no longer add/remove users from the autochecked/editor user groups.Feb 1 2021, 3:51 PM

taavi mentioned this in T288084: Split CentralAuthUtilityService into multiple smaller services.Aug 4 2021, 12:20 PM