Specifically can be seen here: https://en.wikipedia.org/wiki/User:Gwenhope?useskin=timeless

Appears to be a problem with the css to stop images from overflowing the content, as setting a max-width to a percentage value inside a table cell results in a width of 0 because tables are stupid.

While I'd love to give you (or really, whoever made the template) crap for using tables for non-table formatting, this is also going to be an issue on any actual info tables that happen to involve images anywhere, and thus this has helpfully highlighted the issue for us.

Probably just need to make exceptions for tables and infoboxes and crap and be done with it...

In T269970#6685817, @Isarra wrote:

Appears to be a problem with the css to stop images from overflowing the content, as setting a max-width to a percentage value inside a table cell results in a width of 0 because tables are stupid.

While I'd love to give you (or really, whoever made the template) crap for using tables for non-table formatting, this is also going to be an issue on any actual info tables that happen to involve images anywhere, and thus this has helpfully highlighted the issue for us.

Sorry this template has existed for at least a decade before I began actively editing the wiki. Last update to the template was made in 2013 when they switched to local Lua invocation instead of on-wiki template via template code. Regardless I appreciate your quick looking into this issue.

I've also just discovered it applies to {{mbox}} as well, since they both are invocations of the same Lua backend. The difference with mbox is the text vanishes, not the images.

The difference with mbox is the text vanishes, not the images.

O___o

I have... so many questions...

But seriously, keep the weirdness coming, man. This is really helpful!

In T269970#6686164, @Isarra wrote:

But seriously, keep the weirdness coming, man. This is really helpful!

I'll post anything I find that is bugged in this Timeless-based vein.

Here's some screenshots from various template boxes in this class which implement {{mbox}} (or, more-specifically, the {{Message box|mbox}} Lua module)

Okay, so trying to duplicate this locally, it looks like it's not that images break in tables with timeless' new styles, but rather that these new styles combined with the wikipedia tmbox (etc) styles break. So I'm really hoping that is still just in tables...

(The message box module and templates are due for an upgrade from 10 years ago when they were designed, it's just a rather complex design.)

Change 649111 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Limit image overflow limits to not tables

https://gerrit.wikimedia.org/r/649111

Patch fixes image overflow issues confirmed via compiling less -> css and trying it out as user css for Timeless. Message box templates rendering correctly. Recommend patch for publication.

Change 649111 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Limit image overflow limits to not tables

https://gerrit.wikimedia.org/r/649111

Good job Isarra, thanks for the quick fix!