Add edit notice element to New Discussion Tool
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Nov 30 2020, 8:00 PM

Description

This task is about implementing a standardized "edit notice" [i] component within the New Discussion Tool's UI.

Requirements

Meta

Tools: New Discussion Tool
Platforms: Desktop and Mobile

Stories

As a Junior or Senior Contributor who has opened the New Discussion Tool on desktop or mobile, I want to know what – if any – instructions /guidelines I should consider before starting a new discussion topic on a talk page.

Background

There are four kinds of edit notices that can appear within the context of talk pages:

Individual talk pages can contain page-specific messages people see when they click Edit. These messages are defined via the MediaWiki:Editnotice-N-Title user interface message.
All talk pages within a given namespace can also contain the same message people see when they click Edit on a page within said namespace. These messages are defined via the MediaWiki:Editnotice-N user interface message.
All talk pages, within any talk namespace [ii], can also contain the same message people see when they click Edit on a page within a talk namespace. This message is defined via the MediaWiki:Talkpagetext user interface message.
All talk pages that have not yet been created can contain a generic message people see when they click Edit on a page that does not currently exist. This message is defined via the MediaWiki:Newarticletext user interface message.

This task is about creating a UI "component" that will appear when someone opens the New Discussion Tool on a page that has at least one of the three edit notice user interface messages above defined.

Minimum test case

Visit a page on a wiki: 1) Where the New Discussion Tool is available and 2) That contains an edit notice. E.g. https://cs.wikipedia.org/wiki/Wikipedie:Potřebuji_pomoc.
Click the Add topic button at the top of the page
Notice the New Discussion Tool opens with the following edit notice above the Title field:

Upozornění
Prosíme, nevkládejte dotazy nesouvisející s Wikipedií. Tato stránka není všeobecnou internetovou poradnou. Hledáte-li všeobecnou poradnu, můžete vyzkoušet službu Ptejte se knihovny.

Open questions

What projets have specified a MediaWiki:Talkpagetext message? [i]
- 161 projects have specified a MediaWiki:Talkpagetext message per T269033#6699159. Also see: https://global-search.toolforge.org/?namespaces=8&q=.&regex=1&title=Talkpagetext .
Should this component be generalized to all relevant DiscussionTool features (e.g. the Reply Tool)?
- Not at this time.

i. https://www.mediawiki.org/wiki/Manual:Interface/Edit_notice
ii. Any namespace which has odd namespace number (1=Talk, 3=User talk etc.).

Details

	Subject	Repo	Branch	Lines /-
	Show edit notices in the new discussion tool	mediawiki/extensions/DiscussionTools	master	35 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Open	None	T233446 [Epic] New Discussion Tool
Resolved	None	T275256 Make New Topic Tool (desktop) available as opt-out feature at all wikis
Resolved	matmarex	T285117 Add support for the InputBox extension
Resolved	Urbanecm_WMF	T269310 Add support for preloaded text
Resolved	Ryasmeen	T269033 Add edit notice element to New Discussion Tool
Resolved	ppelberg	T270454 Implement edit notice logic
Resolved	Esanders	T272188 VE API: Return structured information about edit notices so they can be filtered by clients

Event Timeline

ppelberg created this task.Nov 30 2020, 8:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2020, 8:00 PM

ppelberg updated the task description. (Show Details)Nov 30 2020, 8:01 PM

ppelberg moved this task from 📚 Backlog to 📢 To Do on the Editing Design board.Dec 2 2020, 4:21 PM

Tacsipacsi updated the task description. (Show Details)Dec 6 2020, 10:33 PM

Tacsipacsi subscribed.

matmarex subscribed.Dec 16 2020, 4:46 PM

Regarding 'talkpagetext': I think we shouldn't display this message. I had a look at the overrides on Wikimedia wikis, and all of them are mostly about signing your comments with ~~~~ (and some even include an image of the signature button in the old wikitext editor toolbar).

If folks want to have a link to https://en.wikipedia.org/wiki/Wikipedia:Talk_page_guidelines (or similar pages) above the tool, then we should introduce a new message to allow this. I'm a little surprised that no one has requested this for the reply tool yet. (Maybe that help page isn't as useful there, since most of it is actually about guidelines on using wikitext and the wikitext editor, but I imagine folks will want to have a link to something.)

A few representative examples:

https://en.wikipedia.org/wiki/MediaWiki:Talkpagetext
https://hi.wikipedia.org/wiki/मीडियाविकि:Talkpagetext
https://ru.wikipedia.org/wiki/MediaWiki:Talkpagetext
https://zh.wikipedia.org/wiki/MediaWiki:Talkpagetext
https://sr.wikipedia.org/wiki/Медијавики:Talkpagetext
https://de.wikibooks.org/wiki/MediaWiki:Talkpagetext

Full list:

af.wikipedia ar.wikipedia az.wikipedia bg.wikipedia bg.wikiquote bn.wikipedia bs.wikipedia ca.wikipedia ca.wikibooks ca.wikiquote ce.wikipedia ckb.wikipedia cs.wikipedia de.wikibooks diq.wikipedia el.wikipedia en.wikipedia en.wikibooks en.wikinews en.wikiversity en.wiktionary es.wikipedia es.wikinews es.wikiquote es.wikiversity et.wikipedia fa.wikipedia fa.wikiquote fi.wikipedia fi.wikiquote fr.wikipedia fr.wikibooks fr.wikinews gag.wikipedia gl.wikipedia gl.wikibooks gl.wikiquote gl.wikisource gu.wikipedia ha.wikipedia he.wikipedia he.wikibooks he.wikinews he.wikisource hi.wikipedia hr.wikipedia ilo.wikipedia is.wikipedia is.wikibooks is.wikiquote it.wikivoyage ja.wikipedia ja.wikibooks ja.wikinews ja.wiktionary kk.wikipedia km.wikipedia km.wiktionary ko.wikipedia ko.wikibooks ko.wikisource ko.wiktionary krc.wikipedia ksh.wikipedia la.wikipedia lv.wikipedia my.wikipedia ne.wikipedia nn.wikipedia no.wikinews oc.wikipedia pa.wiktionary pl.wikinews pms.wikipedia pnb.wikipedia ps.wikipedia ro.wikipedia ro.wikiquote ru.wikipedia ru.wikinews se.wikipedia simple.wikipedia simple.wikiquote simple.wiktionary sl.wikipedia sq.wikinews sr.wikipedia sr.wikiquote sr.wikisource th.wikipedia th.wikibooks th.wikiquote th.wiktionary tr.wikipedia tr.wikibooks tr.wikinews tr.wiktionary ur.wikipedia ur.wikiquote vi.wikipedia vi.wiktionary yi.wikipedia zh-yue.wikipedia zh.wikipedia zh.wikibooks zh.wikinews zh.wikiquote zh.wikisource zh.wiktionary

Change 649944 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Show edit notices in the reply tool (and new discussion tool)

https://gerrit.wikimedia.org/r/649944

gerritbot added a project: Patch-For-Review.Dec 16 2020, 5:44 PM

ppelberg added a project: Editing-team (Kanban Board).Dec 16 2020, 5:45 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Dec 17 2020, 1:23 AM

Thanks for doing that research @matmarex
I agree an wonder if we need it on the message level of the page as opposed to the page frame. cc @ppelberg

We can search for overridden messages with global search tool:

https://global-search.toolforge.org/?q=.&regex=1&namespaces=8&title=Talkpagetext

161 wikis (including sister projects)

ppelberg added a parent task: T270454: Implement edit notice logic.Dec 18 2020, 1:40 AM

ppelberg removed a parent task: T270454: Implement edit notice logic.

ppelberg added a subtask: T270454: Implement edit notice logic.

Notes from today's standup
As we discussed during today's standup meeting, this task cannot be worked on until the newly-created T270454 is resolved.

ppelberg updated the task description. (Show Details)Jan 8 2021, 11:43 PM

Tacsipacsi updated the task description. (Show Details)Jan 10 2021, 1:27 AM

ppelberg mentioned this in T269157: Create more aesthetic cohesion between components in New Discussion .Jan 11 2021, 8:30 PM

matmarex added a parent task: T269310: Add support for preloaded text .Jan 14 2021, 11:21 PM

matmarex mentioned this in T269310: Add support for preloaded text .Jan 14 2021, 11:26 PM

ppelberg edited projects, added Editing-team (Tracking); removed Editing-team (Kanban Board).Jan 20 2021, 5:25 PM

ppelberg moved this task from Backlog to FY2020-21 on the Editing-team (Tracking) board.

Patriccck subscribed.Jan 21 2021, 5:03 PM

ppelberg mentioned this in T273077: Publicize availability of New Discussion Tool as beta feature.Feb 1 2021, 5:17 AM

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Feb 24 2021, 9:08 PM

Test wiki created on Patch Demo by Matma Rex using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/1469c4ab766b236d440e43dc73bfe977/w/

I dusted off my patch from December, and set up the demo wiki linked above. For testing, I imported the edit notice from https://en.wikipedia.org/wiki/Talk:Main_Page to https://patchdemo.wmflabs.org/wikis/1469c4ab766b236d440e43dc73bfe977/w/index.php/Talk:Main_Page (it's particularly bad).

I'm not sure what the next steps here are. Are we prioritizing this now?

The patch is also showing the notice in the reply tool, which I don't think is asked for in the task (nor do I think it is a good idea).

ppelberg mentioned this in T275828: Make volunteers aware of New Discussion Tool's availability as beta feature.Feb 26 2021, 2:59 AM

ppelberg updated the task description. (Show Details)Mar 16 2021, 12:27 AM

ppelberg updated the task description. (Show Details)Mar 16 2021, 12:30 AM

ppelberg updated the task description. (Show Details)Mar 16 2021, 12:35 AM

ppelberg edited projects, added Editing-team; removed Editing-team (Kanban Board).Mar 31 2021, 4:38 AM

ppelberg moved this task from Untriaged to Next Quarter on the Editing-team board.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Jun 4 2021, 10:59 PM

ppelberg closed subtask T270454: Implement edit notice logic as Resolved.Jun 4 2021, 11:04 PM

ppelberg moved this task from Blocked / Needs More Work to Upcoming on the Editing-team (Kanban Board) board.Jun 9 2021, 4:08 PM

In T269033#6862783, @Esanders wrote:

The patch is also showing the notice in the reply tool, which I don't think is asked for in the task (nor do I think it is a good idea).

1. @matmarex can you revise the patch you linked to in T269033#6858570 such that edit notices are shown in the New Discussion Tool exclusively.

ppelberg moved this task from Upcoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jun 18 2021, 12:57 AM

Patch updated

• LZaman mentioned this in T271964: [Release ticket] Make New Discussion Tool available as opt-out feature at partner wikis.Jun 29 2021, 10:19 PM

Change 649944 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Show edit notices in the new discussion tool

https://gerrit.wikimedia.org/r/649944

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 1 2021, 5:36 PM

matmarex edited projects, added Editing QA; removed Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 1 2021, 6:00 PM

• Whatamidoing-WMF mentioned this in T262313: Develop an approach for section=new.Jul 16 2021, 8:59 PM

ToBeFree awarded a token.Jul 17 2021, 5:13 PM

ppelberg moved this task from Inbox to High Priority on the Editing QA board.Jul 29 2021, 7:20 PM

Test Instructions needed.

In T269033#7257051, @Ryasmeen wrote:

Test Instructions needed.

Done.

matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Aug 4 2021, 9:56 PM

ppelberg updated the task description. (Show Details)Aug 6 2021, 8:14 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 10 2021, 9:04 PM

Ryasmeen edited projects, added Verified; removed Editing QA.

ppelberg closed this task as Resolved.Aug 11 2021, 12:24 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 11 2021, 12:24 AM

ppelberg mentioned this in T291893: Show edit notices within the New Discussion Tool on mobile .Sep 27 2021, 9:54 PM

Test wiki on Patch Demo by Matma Rex using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/1469c4ab766b236d440e43dc73bfe977/w/~~

Auntof6 subscribed.Feb 19 2022, 3:26 AM

	F33947252: image.png
	Dec 16 2020, 5:03 PM

	F33947248: image.png
	Dec 16 2020, 5:03 PM

	F33947246: image.png
	Dec 16 2020, 5:03 PM

	F33947250: image.png
	Dec 16 2020, 5:03 PM

Add edit notice element to New Discussion ToolClosed, ResolvedPublicActions