Page MenuHomePhabricator
Create Task
Maniphest T268067

CirrusSearch throwing exceptions due to unhandled unparseable URIs
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

the code in https://gerrit.wikimedia.org/g/mediawiki/extensions/CirrusSearch/ /b711aa5901ec4226b8f7b977b9b23469b9c1b17b/resources/ext.cirrus.serp.js#12 fails to take into account that Uri creation may throw an exception.

This is leading to a high amount of logstash spam that is not easy to reliably filter out

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.11.17/clienterror/?id=AXXXNANNA-3rjFdAoN8f

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.11.17/clienterror/?id=AXXXrQE5BpCrxDVRDZPs

Details

SubjectRepoBranchLines /-
Wrap `new mw.Uri()` constructors in try-catchmediawiki/extensions/CirrusSearchmaster 21 -9
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Nov 17 2020, 7:47 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptNov 17 2020, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson triaged this task as High priority.Nov 17 2020, 7:47 PM
Jdlrobson mentioned this in T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash.Nov 17 2020, 7:56 PM
thcipriani moved this task from Untriaged to Nov 2020 on the Wikimedia-production-error board.Nov 18 2020, 7:26 PM
Gehel moved this task from needs triage to Current work on the Discovery-Search board.Nov 23 2020, 4:19 PM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.
CBogen set the point value for this task to 3.Nov 23 2020, 6:25 PM
CBogen moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
gerritbot added a comment.Dec 1 2020, 7:37 AM

Change 644451 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CirrusSearch@master] Wrap new mw.Uri() constructors in try-catch

https://gerrit.wikimedia.org/r/644451

gerritbot added a project: Patch-For-Review.Dec 1 2020, 7:37 AM
dcausse assigned this task to thiemowmde.Dec 1 2020, 1:44 PM
dcausse moved this task from Ready for Dev -- SWE to Needs review on the Discovery-Search (Current work) board.
dcausse moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Dec 1 2020, 2:25 PM
gerritbot added a comment.Dec 1 2020, 2:42 PM

Change 644451 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Wrap new mw.Uri() constructors in try-catch

https://gerrit.wikimedia.org/r/644451

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 1 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 1 2020, 3:10 PM
Jdlrobson closed this task as Resolved.Dec 11 2020, 4:50 PM

Seeing a pretty clear drop off here :

Screen Shot 2020-12-11 at 8.49.20 AM.png (464×1 px, 58 KB)

Thanks for working on this!
https://logstash.wikimedia.org/goto/5aeadeac5a0d336a1b05

thiemowmde added a comment.Dec 12 2020, 9:06 AM

Happy to help!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits