eh question.. enable line number specifically for Template namespace ? Or for all non-CodeEditor namespaces ?

Hi @TheDJ, the current thinking is to enable line numbering for all namespaces, but only when the syntax highlighter is enabled (so that it's toggled on and off with that setting). The reason is that we believe it could be helpful in situations beyond template creation/maintenance, for example to see where there are line breaks on a page. Line numbering is also already enabled by default in iOS for article pages and has been found to be generally useful for editing there (or at least not disruptive). Open to feedback on that though, if you have any?

Change 618737 had a related patch set uploaded (by Awight; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] [WIP] Experimentally enable line numbering

https://gerrit.wikimedia.org/r/618737

@ECohen_WMDE What should we do when syntax highlighting is enabled on a wikitext content page? The behavior as specificied is going to look like,

@awight I'm not sure I completely understand the question. Do you mean should the numbers show on article pages? The answer would be yes. We are not hiding/showing based on namespaces. Preview looks good!

In T267911#6976890, @ECohen_WMDE wrote:

@awight I'm not sure I completely understand the question. Do you mean should the numbers show on article pages? The answer would be yes. We are not hiding/showing based on namespaces. Preview looks good!

Thanks, yes that was my question :-)

Random feature request for the future: each line number is a permalink to that (revid, line number).

It's challenging to implement the 8px padding in a non-hacky way. Here's what it looks like now in the 2017 wikitext editor,

There was a way:

Upstream patch submitted as https://github.com/codemirror/CodeMirror/pull/6646

I tested the changes locally and they look good, @awight. I was only wondering if the spacing on the left side of the line numbers should also be discussed. Currently it looks a bit larger than in the mock:

I guess the spacing is there to leave enough space for possible large numbers, but maybe those could also overlap the title to save some space for the main content? @ECohen_WMDE do you have an opinion on this?

Change 618737 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Enable line numbering

https://gerrit.wikimedia.org/r/618737

Change 677849 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CodeMirror@master] Reposition line numbering to be flush with the title

https://gerrit.wikimedia.org/r/677849

Change 677849 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Reposition line numbering to be flush with the title

https://gerrit.wikimedia.org/r/677849

In T267911#6976890, @ECohen_WMDE wrote:

We are not hiding/showing based on namespaces.

Templates seem fine, but I'm not sure how the editing team feels about adding line numbers to the content editing experience. CC @ppelberg, @iamjessklein

A less serious issue is that the act of enabling syntax highlighting now changes the width of the editor. If you are half way down a content page with wrapping lines, this will result in your scroll position being lost.

In T267911#6984660, @Esanders wrote:

...I'm not sure how the editing team feels about adding line numbers to the content editing experience. CC @ppelberg, @iamjessklein

Thank you for the bump, @Esanders.

@Lena_WMDE: I sent you an email with a question about modifying next week's planned deployment.

In T267911#6984681, @Esanders wrote:

A less serious issue is that the act of enabling syntax highlighting now changes the width of the editor. If you are half way down a content page with wrapping lines, this will result in your scroll position being lost.

Good point! I was able to verify that the bug already exists in the 2010 and 2017 wikitext editors without line numbering, so have split that off into T279768. It's very possible that line numbering will make the jump worse, but I expect that any potential fix will equally apply with or without the line numbering.

Test wiki created on Patch Demo by PPelberg (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/648abb13e9/w/

Change 678568 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CodeMirror@master] Enable line numbering only on configured namespaces

https://gerrit.wikimedia.org/r/678568

Change 678568 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Enable line numbering only on configured namespaces

https://gerrit.wikimedia.org/r/678568

Change 678606 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] [beta] Enable line numbering on all namespaces

https://gerrit.wikimedia.org/r/678606

Change 678606 merged by jenkins-bot:

[operations/mediawiki-config@master] [beta] Enable line numbering on all namespaces

https://gerrit.wikimedia.org/r/678606

Mentioned in SAL (#wikimedia-cloud) [2021-04-13T07:46:05Z] <awight> enable syntax highlighting line numbering on all namespaces (T267911)

Change 679491 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CodeMirror@master] Reflect new event name as it was upstreamed

https://gerrit.wikimedia.org/r/679491

Here is a code snippet everybody can copy-paste to their own https://de.wikipedia.org/wiki/Special:MyPage/common.css page in case they want to hide the line numbers.

/* Hide line numbers in both the 2010 and 2017 wikitext editors */
.CodeMirror-gutters, .CodeMirror-gutter-wrapper {
    display: none;
}
.CodeMirror-sizer, .ve-ce-attachedRootNode {
    margin-left: 0 !important;
}

@JStrodt_WMDE and WMDE-Tech-Communication, we briefly talked about this.

In T267911#7044908, @thiemowmde wrote:

Here is a code snippet everybody can copy-paste to their own https://de.wikipedia.org/wiki/Special:MyPage/common.css page in case they want to hide the line numbers.

@thiemowmde Thanks, we'll take care of it.

In the 2017 wikitext editor, update styling to remove the background gray and add padding (see below).

What is the reasoning behind this? Personally I think it is more readable with a background and border like in the 2010 editor:

This was a decision by our UX team, together with PM @Lena_WMDE. Personally I think the gray box looks out of place, like a debugging layer that is not meant to be there for regular users.

Test wiki on Patch demo by PPelberg (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/648abb13e9/w/

Change #679491 abandoned by MusikAnimal:

[mediawiki/extensions/CodeMirror@master] Reflect new event name as it was upstreamed

Reason:

stale; feel free to re-open if desired

https://gerrit.wikimedia.org/r/679491